- User Since
- May 24 2017, 1:50 AM (150 w, 2 d)
Jan 29 2020
Sep 6 2019
Mar 4 2019
As it is not needed. I'm closing this.
Thanks for the feedback.
Mar 1 2019
Nov 19 2018
Committed as r347222.
Nov 16 2018
committed a long time ago
Jun 25 2018
Apr 5 2018
Mar 28 2018
Commited as r328614
Mar 27 2018
Mar 19 2018
Mar 12 2018
Didn't manage to append to this code review, so I submitted https://reviews.llvm.org/D44389.
Feb 28 2018
Dec 20 2017
Thanks for the feedback. This is commited as r321160 including a test and code simplification as suggested.
Dec 14 2017
Dec 12 2017
Notice: I'll update this review with an automated test.
Sep 1 2017
Commited as r312314
I've used ts.sample_fields just because is the same list the v4_graph will use to grab the value back.
Sending a new version in a minute.
Aug 31 2017
Jul 18 2017
commited as r308230
Jul 14 2017
@cmatthews Do you mind to commit this change for me as I don't have commit access yet ?
Jul 12 2017
Applying code review suggestions.
I'll submit a new version including these fixes.
- Improve testing output to check the generated labels
- Small change to escape a bare & that crashes xml.etree.ElementTree
- sync with current SVN rev.
Jul 5 2017
Jun 30 2017
@dlj Thanks for the fix. It runs fine with ToT lit and ToT test-suite.
Jun 29 2017
Hi. There are some failures on LLVM test-suite after this code was merged.
Jun 27 2017
@cmatthews I've found one docstring that was incorrectly changed. Please let me know if you were talking about a different one when you said "Please fix comment" (or even more than one).
- Updated the svn revision, solved a few conflicts (namely main.py).
- Renamed _error to _fatal
- Adjusted a docstring (action_runtest) that was changed by mistake
Jun 1 2017
@cmatthews: I first tried using argparse, but ran into issues, as explained below. So, instead I decided to try using click to fix PR32789. Does this patch look like what you had in mind?
May 25 2017
Created a new review, adding llvm-commits -> https://reviews.llvm.org/D33541