Page MenuHomePhabricator

[MS] Fix packed struct layout for arrays of aligned non-record types
ClosedPublic

Authored by rnk on Apr 8 2020, 2:09 PM.

Details

Summary

In particular, this affects Clang's vectors. Users encounter this issue
when a struct contains an __m128 type.

Fixes PR45420

Diff Detail

Event Timeline

rnk created this revision.Apr 8 2020, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 2:09 PM
Herald added a subscriber: jfb. · View Herald Transcript
rjmccall accepted this revision.Apr 10 2020, 10:52 PM

Okay, so this is basically just saying that the required-alignment-defeats-packed rule looks through arrays? Make sense. LGTM.

This revision is now accepted and ready to land.Apr 10 2020, 10:52 PM
This revision was automatically updated to reflect the committed changes.