[SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag

[vitalybuka]

compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline_bool_flag.cpp

5

can you add comment why it's unsupported here, and XFAIL tsan

[pratyai]

compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline_bool_flag.cpp

5

This is something I just copied from https://reviews.llvm.org/source/llvm-github/browse/master/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline8bit_counter.cpp, but cannot find a reference why exactly darwin and tsan are problem.

I can see that trying to instrument both thread and coverage emits a warning about just ignoring the latter (a.cc is just some helloworld code).
/tmp $ clang++ -g a.cc -fsanitize=thread -fsanitize-coverage=trace-pc-guard
clang: warning: argument unused during compilation: '-fsanitize-coverage=trace-pc-guard' [-Wunused-command-line-argument]

The i38c-darwin was there from the version#0 of that^ file. Although originally it had more entries, some of which got removed in https://reviews.llvm.org/rGdd862f9106199ce2dd04ebc93e9bfd203465c1ee.

Not really sure what to comment beside // Kept same as 'sanitizer_coverage_inline8bit_counter.cpp'

[vitalybuka]

I'll submit this a little bit later

[pratyai]

In D77638#1971542, @vitalybuka wrote:

I'll submit this a little bit later

I realized only now that I didn't update a few files in compiler-rt that provides weak, empty implementations:

• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_interface_internal.h
• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_interface.inc
• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp
• https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/fuzzer/FuzzerTracePC.cpp

(the last one was the reason of the fuzzer failure on the previous diff I guess)

Should I add them in this diff (/ another diff / not necessary)?

[vitalybuka]

Yes, please.

In D77638#1971544, @pratyai wrote:

In D77638#1971542, @vitalybuka wrote:

I'll submit this a little bit later

I realized only now that I didn't update a few files in compiler-rt that provides weak, empty implementations:

• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_interface_internal.h
• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_interface.inc
• https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp
• https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/fuzzer/FuzzerTracePC.cpp

(the last one was the reason of the fuzzer failure on the previous diff I guess)

Should I add them in this diff (/ another diff / not necessary)?

[thakis]

vitalybuka: See the "fatal error" on http://reviews.llvm.org/rGd6525eff5 . Is it intentional (or known) that these section names are too long for mach-o?

[fhahn]

It looks like this change breaks some macOS builds, e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/8593/

I’ve disabled it for x86_64-darwin as well (it was already unsupported for i386-darwin) in d6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707

It would be great if you could take a look.

[pratyai]

In D77638#1974129, @fhahn wrote:

It looks like this change breaks some macOS builds, e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/8593/

I’ve disabled it for x86_64-darwin as well (it was already unsupported for i386-darwin) in d6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707

It would be great if you could take a look.

Sorry for the breakage; the problematic section was added in D77244 (SanCovBoolFlagSectionName in llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp). I was wondering why the previous section name was dropping the vowels, but didn't realize that there was a character restriction.

If you think just shortening the name to something like sancov_bools would be sufficient, I can send a diff (, how do I test it for mac builds though?).

Thanks!

compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline_bool_flag.cpp

+// Tests -fsanitize-coverage=inline-bool-flag,pc-table
+//
+// REQUIRES: has_sancovcc,stable-runtime
+// UNSUPPORTED: i386-darwin
+//
+// RUN: %clangxx -O0 %s -fsanitize-coverage=inline-bool-flag,pc-table -o %t
+// RUN: %run %t 2>&1 | FileCheck %s
+// XFAIL: tsan
+
+#include <assert.h>
+#include <stdint.h>
+#include <stdio.h>
+
+const bool *first_flag;
+
+extern "C" void __sanitizer_cov_bool_flag_init(const bool *start,
+                                               const bool *end) {
+  printf("INIT: %p %p\n", start, end);
+  assert(end - start > 1);
+  first_flag = start;
+}
+
+uintptr_t FirstPC;
+uintptr_t FirstPCFlag;
+
+extern "C" void __sanitizer_cov_pcs_init(const uintptr_t *pcs_beg,
+                                         const uintptr_t *pcs_end) {
+  const uintptr_t *B = (const uintptr_t *)pcs_beg;
+  const uintptr_t *E = (const uintptr_t *)pcs_end;
+  assert(B + 1 < E);
+  FirstPC = B[0];
+  FirstPCFlag = B[1];
+}
+
+int main() {
+  assert(first_flag);
+  assert(*first_flag);
+  assert(FirstPC == (uintptr_t)&main);
+  assert(FirstPCFlag == 1);
+  fprintf(stderr, "PASS\n");
+  // CHECK: PASS
+}