This is an archive of the discontinued LLVM Phabricator instance.

Differential D77889

[SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it.
ClosedPublic

Authored by pratyai on Apr 10 2020, 11:10 AM.

Details

Reviewers
vitalybuka
Commits
rG0c61e911007f: [SanitizerCoverage] The section name for inline-bool-flag was too long for…
Summary

Following up on the comments on D77638.

Not undoing rGd6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707 here at the moment, since I don't know how to test mac builds. Please let me know if I should include that here too.

Diff Detail

Event Timeline

pratyai created this revision.Apr 10 2020, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 11:10 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B52702: Diff 256620!Apr 10 2020, 11:28 AM
pratyai updated this revision to Diff 256626.Apr 10 2020, 12:46 PM
pratyai edited the summary of this revision. (Show Details)Apr 10 2020, 1:11 PM
pratyai added a reviewer: vitalybuka.
Harbormaster completed remote builds in B52707: Diff 256626.Apr 10 2020, 1:26 PM
vitalybuka accepted this revision.Apr 13 2020, 11:46 PM
This revision is now accepted and ready to land.Apr 13 2020, 11:46 PM
pratyai updated this revision to Diff 257241.Apr 14 2020, 2:27 AM
Closed by commit rG0c61e911007f: [SanitizerCoverage] The section name for inline-bool-flag was too long for… (authored by pratyai, committed by vitalybuka). · Explain WhyApr 14 2020, 2:37 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B53094: Diff 257241!Apr 14 2020, 3:09 AM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
2 lines
test/
Instrumentation/
SanitizerCoverage/
4 lines

Diff 257245

llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
static const char *const SanCov8bitCountersInitName = static const char *const SanCov8bitCountersInitName =
"__sanitizer_cov_8bit_counters_init"; "__sanitizer_cov_8bit_counters_init";
static const char *const SanCovBoolFlagInitName = static const char *const SanCovBoolFlagInitName =
"__sanitizer_cov_bool_flag_init"; "__sanitizer_cov_bool_flag_init";
static const char *const SanCovPCsInitName = "__sanitizer_cov_pcs_init"; static const char *const SanCovPCsInitName = "__sanitizer_cov_pcs_init";
static const char *const SanCovGuardsSectionName = "sancov_guards"; static const char *const SanCovGuardsSectionName = "sancov_guards";
static const char *const SanCovCountersSectionName = "sancov_cntrs"; static const char *const SanCovCountersSectionName = "sancov_cntrs";
static const char *const SanCovBoolFlagSectionName = "sancov_bool_flag"; static const char *const SanCovBoolFlagSectionName = "sancov_bools";
static const char *const SanCovPCsSectionName = "sancov_pcs"; static const char *const SanCovPCsSectionName = "sancov_pcs";
static const char *const SanCovLowestStackName = "__sancov_lowest_stack"; static const char *const SanCovLowestStackName = "__sancov_lowest_stack";
static cl::opt<int> ClCoverageLevel( static cl::opt<int> ClCoverageLevel(
"sanitizer-coverage-level", "sanitizer-coverage-level",
cl::desc("Sanitizer Coverage. 0: none, 1: entry block, 2: all blocks, " cl::desc("Sanitizer Coverage. 0: none, 1: entry block, 2: all blocks, "
"3: all blocks and critical edges"), "3: all blocks and critical edges"),
▲ Show 20 Lines • Show All 920 Lines • Show Last 20 Lines

llvm/test/Instrumentation/SanitizerCoverage/inline-bool-flag.ll

; Test -sanitizer-coverage-inline-bool-flag=1 ; Test -sanitizer-coverage-inline-bool-flag=1
; RUN: opt < %s -sancov -sanitizer-coverage-level=1 -sanitizer-coverage-inline-bool-flag=1 -S | FileCheck %s ; RUN: opt < %s -sancov -sanitizer-coverage-level=1 -sanitizer-coverage-inline-bool-flag=1 -S | FileCheck %s
; RUN: opt < %s -passes='module(sancov-module)' -sanitizer-coverage-level=1 -sanitizer-coverage-inline-bool-flag=1 -S | FileCheck %s ; RUN: opt < %s -passes='module(sancov-module)' -sanitizer-coverage-level=1 -sanitizer-coverage-inline-bool-flag=1 -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
define void @foo() { define void @foo() {
entry: entry:
; CHECK: @__sancov_gen_ = private global [1 x i1] zeroinitializer, section "__sancov_bool_flag", comdat($foo), align 1, !associated !0 ; CHECK: @__sancov_gen_ = private global [1 x i1] zeroinitializer, section "__sancov_bools", comdat($foo), align 1, !associated !0
; CHECK: store i1 true, i1* getelementptr inbounds ([1 x i1], [1 x i1]* @__sancov_gen_, i64 0, i64 0), align 1, !nosanitize !1 ; CHECK: store i1 true, i1* getelementptr inbounds ([1 x i1], [1 x i1]* @__sancov_gen_, i64 0, i64 0), align 1, !nosanitize !1
ret void ret void
} }
; CHECK: call void @__sanitizer_cov_bool_flag_init(i1* bitcast (i1** @__start___sancov_bool_flag to i1*), i1* bitcast (i1** @__stop___sancov_bool_flag to i1*)) ; CHECK: call void @__sanitizer_cov_bool_flag_init(i1* bitcast (i1** @__start___sancov_bools to i1*), i1* bitcast (i1** @__stop___sancov_bools to i1*))