This is an archive of the discontinued LLVM Phabricator instance.

[RDA] Don't adjust ReachingDefDefaultVal (NFCI)
ClosedPublic

Authored by nikic on Apr 5 2020, 10:28 AM.

Details

Summary

At the end of a basic block, RDA adjusts all the reaching defs it found to be relative to the end of the basic block, rather than the start of it. However, it also does this to registers which don't have a reaching def, indicated by ReachingDefDefaultVal. This means that at the entry of a successor block, we end up not skipping these incoming reaching definitions, and insert them into the reaching definition list. This is ultimately harmless, but causes unnecessary work and is logically not right.

Diff Detail

Event Timeline

nikic created this revision.Apr 5 2020, 10:28 AM
samparker accepted this revision.Apr 6 2020, 12:59 AM

Thanks.

This revision is now accepted and ready to land.Apr 6 2020, 12:59 AM
This revision was automatically updated to reflect the committed changes.