Page MenuHomePhabricator

[clang-tools-extra] NFC: Fix trivial typo in documents and comments
ClosedPublic

Authored by kiszk on Apr 4 2020, 3:10 AM.

Diff Detail

Event Timeline

kiszk created this revision.Apr 4 2020, 3:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2020, 3:10 AM

You used codespell for this?
Thanks

kiszk added a comment.Apr 4 2020, 6:13 AM

I used aspell for this.

Eugene.Zelenko added a project: Restricted Project.
sammccall accepted this revision.Apr 4 2020, 11:34 AM

Thank you!

clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp
48

Did you update the actual generated diagnostic in clang-tidy/fuchsia/MultipleInheritanceCheck.cpp? I don't see it in this patch.

This revision is now accepted and ready to land.Apr 4 2020, 11:34 AM
kiszk updated this revision to Diff 255071.Apr 4 2020, 11:53 AM

address review comment

kiszk added inline comments.Apr 4 2020, 11:56 AM
clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp
48

Good catch. I also updated clang-tidy/fuchsia/MultipleInheritanceCheck.cpp.

This revision was automatically updated to reflect the committed changes.
kiszk updated this revision to Diff 255119.Apr 4 2020, 11:18 PM

This includes a fix to break the llvm build