Currently this code exists in widenScalar for G_MERGE_VALUE
sources. I'm not sure if the existing expansion in widenScalar should
be removed or not. The widenScalar variant tries to extend to the
requested size, but this just uses the original bitwidth.
Details
Details
Diff Detail
Diff Detail
Event Timeline
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
4826 | Should this check be done before we create new instructions? Not sure what the current policy for this is. I'm also fine with leaving it down here since it will abort legalization anyway. |
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
4826 | I used to try avoiding creating instructions, but as you said it will be deleted |
Should this check be done before we create new instructions? Not sure what the current policy for this is. I'm also fine with leaving it down here since it will abort legalization anyway.