This is an archive of the discontinued LLVM Phabricator instance.

Differential D77098

Restrict test to x86-only
AbandonedPublic

Authored by bcain on Mar 30 2020, 2:54 PM.

Details

Reviewers
grimar
• espindola
jhenderson
MaskRay

Diff Detail

Unit TestsFailed

TimeTest
180 mslldb-unit.Host/_/HostTests::Unknown Unit Message ("")

Event Timeline

bcain created this revision.Mar 30 2020, 2:54 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 30 2020, 2:54 PM
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, rupprecht, MaskRay, emaste. · View Herald Transcript
MaskRay added a comment.Mar 30 2020, 3:34 PM

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

MaskRay requested changes to this revision.Mar 30 2020, 3:34 PM
This revision now requires changes to proceed.Mar 30 2020, 3:34 PM
Harbormaster failed remote builds in B51035: Diff 253711!Mar 30 2020, 4:24 PM
bcain added a comment.Mar 30 2020, 4:51 PM
In D77098#1951149, @MaskRay wrote:

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

Tsk, my mistake, then. This test fails when -DLLVM_DEFAULT_TARGET_TRIPLE is set to hexagon-unknown-elf and I assumed that it might not make sense to include if x86 wasn't built.

bcain abandoned this revision.Mar 30 2020, 4:52 PM
MaskRay added a comment.Mar 30 2020, 5:17 PM
In D77098#1951328, @bcain wrote:
In D77098#1951149, @MaskRay wrote:

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

Tsk, my mistake, then. This test fails when -DLLVM_DEFAULT_TARGET_TRIPLE is set to hexagon-unknown-elf and I assumed that it might not make sense to include if x86 wasn't built.

Can you shared the output when -DLLVM_DEFAULT_TARGET_TRIPLE=hexagon-unknown-elf is set? If there is an issue we should fix it, but the test is unlikely responsible.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
2 lines

Diff 253711

llvm/test/tools/llvm-readobj/ELF/reloc-addends.test

## Check how llvm-readobj and llvm-readelf tools dump addends of relocations. ## Check how llvm-readobj and llvm-readelf tools dump addends of relocations.
# REQUIRES: x86-registered-target
# RUN: yaml2obj --docnum=1 -DENCODE=LSB -DTYPE=SHT_RELA %s -o %t.le64.rela # RUN: yaml2obj --docnum=1 -DENCODE=LSB -DTYPE=SHT_RELA %s -o %t.le64.rela
# RUN: llvm-readobj -r %t.le64.rela | FileCheck %s --check-prefix=LLVM-RELA64 # RUN: llvm-readobj -r %t.le64.rela | FileCheck %s --check-prefix=LLVM-RELA64
# RUN: llvm-readelf -r %t.le64.rela | FileCheck %s --check-prefix=GNU-RELA64 # RUN: llvm-readelf -r %t.le64.rela | FileCheck %s --check-prefix=GNU-RELA64
# LLVM-RELA64: R_X86_64_NONE - 0x0{{$}} # LLVM-RELA64: R_X86_64_NONE - 0x0{{$}}
# LLVM-RELA64-NEXT: R_X86_64_NONE - 0x1{{$}} # LLVM-RELA64-NEXT: R_X86_64_NONE - 0x1{{$}}
# LLVM-RELA64-NEXT: R_X86_64_NONE - 0xFFFFFFFFFFFFFFFF{{$}} # LLVM-RELA64-NEXT: R_X86_64_NONE - 0xFFFFFFFFFFFFFFFF{{$}}
# LLVM-RELA64-NEXT: R_X86_64_NONE - 0x7FFFFFFFFFFFFFFF{{$}} # LLVM-RELA64-NEXT: R_X86_64_NONE - 0x7FFFFFFFFFFFFFFF{{$}}
▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines