Page MenuHomePhabricator

Restrict test to x86-only
AbandonedPublic

Authored by bcain on Mar 30 2020, 2:54 PM.

Diff Detail

Unit TestsFailed

TimeTest
180 mslldb-unit.Host/_/HostTests::ConnectionFileDescriptorTest.TCPGetURIv6
Note: Google Test filter = ConnectionFileDescriptorTest.TCPGetURIv6 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.

Event Timeline

bcain created this revision.Mar 30 2020, 2:54 PM

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

MaskRay requested changes to this revision.Mar 30 2020, 3:34 PM
This revision now requires changes to proceed.Mar 30 2020, 3:34 PM
bcain added a comment.Mar 30 2020, 4:51 PM

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

Tsk, my mistake, then. This test fails when -DLLVM_DEFAULT_TARGET_TRIPLE is set to hexagon-unknown-elf and I assumed that it might not make sense to include if x86 wasn't built.

bcain abandoned this revision.Mar 30 2020, 4:52 PM

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

Tsk, my mistake, then. This test fails when -DLLVM_DEFAULT_TARGET_TRIPLE is set to hexagon-unknown-elf and I assumed that it might not make sense to include if x86 wasn't built.

Can you shared the output when -DLLVM_DEFAULT_TARGET_TRIPLE=hexagon-unknown-elf is set? If there is an issue we should fix it, but the test is unlikely responsible.