This is an archive of the discontinued LLVM Phabricator instance.

Differential D76823

[WebAssembly] Add test for event section order change
ClosedPublic

Authored by aheejin on Mar 25 2020, 9:52 PM.

Details

Reviewers
sbc100
tlively
Commits
rGf033f201a7c8: [WebAssembly] Add test for event section order change
Summary

This adds a test for D76752. Now the global section comes after the
event section, and this change makes sure it is satisfied.

Diff Detail

Event Timeline

aheejin created this revision.Mar 25 2020, 9:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2020, 9:52 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, dschuff. · View Herald Transcript
aheejin mentioned this in D76752: [WebAssembly] Move event section before global section.Mar 25 2020, 9:52 PM
Harbormaster failed remote builds in B50487: Diff 252744!Mar 25 2020, 10:44 PM
tlively accepted this revision.Mar 25 2020, 11:25 PM

Maybe add a comment saying why the new line is important.

This revision is now accepted and ready to land.Mar 25 2020, 11:25 PM
aheejin updated this revision to Diff 252904.Mar 26 2020, 10:58 AM
  • Add comment
Closed by commit rGf033f201a7c8: [WebAssembly] Add test for event section order change (authored by aheejin). · Explain WhyMar 26 2020, 11:24 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B50572: Diff 252904!Mar 26 2020, 11:24 AM

Revision Contents

PathSize
lld/
test/
wasm/
3 lines

Diff 252904

lld/test/wasm/event-section.ll

Show All 26 Lines
; CHECK-NEXT: - I32 ; CHECK-NEXT: - I32
; CHECK-NEXT: ReturnTypes: [] ; CHECK-NEXT: ReturnTypes: []
; CHECK: - Type: EVENT ; CHECK: - Type: EVENT
; CHECK-NEXT: Events: ; CHECK-NEXT: Events:
; CHECK-NEXT: - Index: 0 ; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Attribute: 0 ; CHECK-NEXT: Attribute: 0
; CHECK-NEXT: SigIndex: 1 ; CHECK-NEXT: SigIndex: 1
; Global section has to come after event section
; CHECK: - Type: GLOBAL