[WebAssembly] Move event section before global section

[aheejin]

Summary

https://github.com/WebAssembly/exception-handling/issues/98

Also this moves many parts of code to make code align with the section
order, even if they don't affect the output.

[aheejin]

• clang-format

[aheejin]

llvm/lib/Object/WasmObjectFile.cpp

1653

Hmm, clang-format makes this look ugly, and I think I remember you decided not to format this code intentionally before, but having consistent style throughtout wasm code is also better. WDYT? @tlively

[tlively]

LGTM!

llvm/lib/Object/WasmObjectFile.cpp

1653

Yeah, I think I did intentionally exclude this code from styling before, but I'd be ok letting clang-format style it now. I think it would look better if we move the inline comments to their own lines.

[aheejin]

llvm/lib/Object/WasmObjectFile.cpp

1653

Good idea! Done.

[aheejin]

Move inline comments to their own lines

[sbc100]

I surprised this didn't effect any tests. Are we missing tests?

[aheejin]

V8 validation fails without this. I'm not sure if there's a way test v8 validation w/ LLVM unit tests?

[tlively]

Even without running V8 or some other external validator, I agree it's surprising that the change in section order did not cause any tests to change. I guess most of our tests just look at a single section rather than a sequence of sections? And most don't have an events section at all.

[aheejin]

Hmm, come to think of it, I can add a test change that cannot run without this change after all. Thanks for suggestions. Done in D76823.