https://github.com/WebAssembly/exception-handling/issues/98
Also this moves many parts of code to make code align with the section
order, even if they don't affect the output.
Differential D76752
[WebAssembly] Move event section before global section aheejin on Mar 24 2020, 8:48 PM. Authored by
Details https://github.com/WebAssembly/exception-handling/issues/98 Also this moves many parts of code to make code align with the section
Diff Detail
Event TimelineComment Actions LGTM!
Comment Actions V8 validation fails without this. I'm not sure if there's a way test v8 validation w/ LLVM unit tests? Comment Actions Even without running V8 or some other external validator, I agree it's surprising that the change in section order did not cause any tests to change. I guess most of our tests just look at a single section rather than a sequence of sections? And most don't have an events section at all. Comment Actions Hmm, come to think of it, I can add a test change that cannot run without this change after all. Thanks for suggestions. Done in D76823. |