Page MenuHomePhabricator

[AArch64][SVE] Add more DestructiveBinaryImm DestructiveInstType patterns
Needs ReviewPublic

Authored by cameron.mcinally on Mar 23 2020, 2:05 PM.

Details

Summary

This patch starts filling in some of the DestructiveBinaryImm DestructiveInstType patterns. Both zero merging and undef merging are included.

It's questionable whether the undef merging tests are needed. The select with an undefined false operand should be combined away, so I'm not sure there's a lot of value in those. Thoughts?

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2020, 2:05 PM

Ping.

Just noticed I added undef merging tests here, but those can probably be removed. DAGCombine (or similar) will remove the undef before we get to the patterns, so they're not really testing anything.