This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Prepare to allow other target unit tests
ClosedPublic

Authored by arsenm on Mar 22 2020, 4:09 PM.

Details

Summary

Currently all GlobalISel unittests use a hardcoded AArch64 target
machine. Factor this so I can write some for AMDGPU specific known
bits unittests.

Diff Detail

Event Timeline

arsenm created this revision.Mar 22 2020, 4:09 PM
dsanders accepted this revision.Mar 23 2020, 9:36 AM

LGTM aside from that orphaned comment

llvm/unittests/CodeGen/GlobalISel/GISelMITest.h
56–57

The function this comment refers to is gone

This revision is now accepted and ready to land.Mar 23 2020, 9:36 AM