This is an archive of the discontinued LLVM Phabricator instance.

Differential D76546

[Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.
ClosedPublic

Authored by sidneym on Mar 21 2020, 10:50 AM.

Details

Reviewers
kparzysz
adasgupt
bcain
bcahoon
Commits
rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set.
Summary

Seeing errors while building the c++ library:
atomic:2756:16: error: use of undeclared identifier '__libcpp_signed_lock_free'

typedef atomic<__libcpp_signed_lock_free> atomic_signed_lock_free;

Diff Detail

Event Timeline

sidneym created this revision.Mar 21 2020, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2020, 10:50 AM
Herald added subscribers: cfe-commits, jfb. · View Herald Transcript
Harbormaster failed remote builds in B50000: Diff 251851!Mar 21 2020, 11:44 AM
sidneym marked an inline comment as done.Mar 21 2020, 7:07 PM
sidneym added inline comments.
clang/test/Preprocessor/hexagon-predefines.c
117

The extra line break?

sidneym updated this revision to Diff 251896.Mar 22 2020, 9:18 AM

remove extra line break.

Harbormaster completed remote builds in B50031: Diff 251896.Mar 22 2020, 10:08 AM
bcain accepted this revision.Mar 26 2020, 7:02 AM

LGTM

This revision is now accepted and ready to land.Mar 26 2020, 7:02 AM
sidneym added a reviewer: bcahoon.Mar 26 2020, 7:53 AM
bcahoon accepted this revision.Mar 26 2020, 3:44 PM
Closed by commit rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set. (authored by sidneym). · Explain WhyMar 30 2020, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
1 line
test/
Preprocessor/
15 lines

Diff 253640

clang/lib/Basic/Targets/Hexagon.h

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines HexagonTargetInfo(const llvm::Triple &Triple, const TargetOptions &)
// {} in inline assembly are packet specifiers, not assembly variant // {} in inline assembly are packet specifiers, not assembly variant
// specifiers. // specifiers.
NoAsmVariants = true; NoAsmVariants = true;
LargeArrayMinWidth = 64; LargeArrayMinWidth = 64;
LargeArrayAlign = 64; LargeArrayAlign = 64;
UseBitFieldTypeAlignment = true; UseBitFieldTypeAlignment = true;
ZeroLengthBitfieldBoundary = 32; ZeroLengthBitfieldBoundary = 32;
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
// These are the default values anyway, but explicitly make sure // These are the default values anyway, but explicitly make sure
// that the size of the boolean type is 8 bits. Bool vectors are used // that the size of the boolean type is 8 bits. Bool vectors are used
// for modeling predicate registers in HVX, and the bool -> byte // for modeling predicate registers in HVX, and the bool -> byte
// correspondence matches the HVX architecture. // correspondence matches the HVX architecture.
BoolWidth = BoolAlign = 8; BoolWidth = BoolAlign = 8;
} }
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines

clang/test/Preprocessor/hexagon-predefines.c

Show First 20 Lines • Show All 107 Lines • ▼ Show 20 Lines
// RUN: %s -check-prefix CHECK-LINUX // RUN: %s -check-prefix CHECK-LINUX
// CHECK-LINUX: #define __gnu_linux__ 1 // CHECK-LINUX: #define __gnu_linux__ 1
// CHECK-LINUX: #define __linux 1 // CHECK-LINUX: #define __linux 1
// CHECK-LINUX: #define __linux__ 1 // CHECK-LINUX: #define __linux__ 1
// CHECK-LINUX: #define __unix 1 // CHECK-LINUX: #define __unix 1
// CHECK-LINUX: #define __unix__ 1 // CHECK-LINUX: #define __unix__ 1
// CHECK-LINUX: #define linux 1 // CHECK-LINUX: #define linux 1
// CHECK-LINUX: #define unix 1 // CHECK-LINUX: #define unix 1
// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-linux-musl \
sidneymAuthorUnsubmitted
Done
ReplyInline Actions

The extra line break?

sidneym: The extra line break?
// RUN: -target-cpu hexagonv67 -target-feature +hvxv67 \
// RUN: -target-feature +hvx-length128b %s | FileCheck \
// RUN: %s -check-prefix CHECK-ATOMIC
// CHECK-ATOMIC: #define __CLANG_ATOMIC_BOOL_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_CHAR16_T_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_CHAR32_T_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_CHAR_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_INT_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_LLONG_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_LONG_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_POINTER_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_SHORT_LOCK_FREE 2
// CHECK-ATOMIC: #define __CLANG_ATOMIC_WCHAR_T_LOCK_FREE 2