This is an archive of the discontinued LLVM Phabricator instance.

Differential D76469

Enabled CUDA offloading on aarch64 host
ClosedPublic

Authored by tianshilei1992 on Mar 19 2020, 6:31 PM.

Details

Reviewers
jdoerfert
JonChesterfield
grokos
AndreyChurbanov
ABataev
Commits
rG0a42c9bfe4ea: Enable CUDA offloading on aarch64 host
Summary

I've tried on ORNL Wombat cluster which is aarch64 host with NVIDIA GPUs. Offloading works fine. All 19 tests in libomptarget passed.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Mar 19 2020, 6:31 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMar 19 2020, 6:31 PM
Herald added subscribers: openmp-commits, danielkiss, kristof.beyls, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B49821: Diff 251523.Mar 19 2020, 7:12 PM
jdoerfert added reviewers: JonChesterfield, grokos, AndreyChurbanov, ABataev.Mar 19 2020, 9:07 PM
JonChesterfield added a comment.Mar 20 2020, 4:38 AM

Sounds good. Thanks for testing it.

grokos accepted this revision.Mar 20 2020, 11:58 AM

Building the CUDA plugin on aarch64 hosts was enabled in the ykt branch ages ago, so the configuration has been tested extensively. LGTM.

This revision is now accepted and ready to land.Mar 20 2020, 11:58 AM
tianshilei1992 added a comment.Mar 20 2020, 12:41 PM

I didn't have privilege to merge. Could someone do it for me?

grokos added a comment.Mar 20 2020, 3:40 PM

Done!

Closed by commit rG0a42c9bfe4ea: Enable CUDA offloading on aarch64 host (authored by grokos). · Explain WhyMar 20 2020, 3:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
openmp/
libomptarget/
plugins/
cuda/
8 lines

Diff 251523

openmp/libomptarget/plugins/cuda/CMakeLists.txt

##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Build a plugin for a CUDA machine if available. # Build a plugin for a CUDA machine if available.
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
if (NOT(CMAKE_SYSTEM_PROCESSOR MATCHES "(x86_64)|(ppc64le)$" AND CMAKE_SYSTEM_NAME MATCHES "Linux")) if (NOT(CMAKE_SYSTEM_PROCESSOR MATCHES "(x86_64)|(ppc64le)|(aarch64)$" AND CMAKE_SYSTEM_NAME MATCHES "Linux"))
libomptarget_say("Not building CUDA offloading plugin: only support CUDA in Linux x86_64 or ppc64le hosts.") libomptarget_say("Not building CUDA offloading plugin: only support CUDA in Linux x86_64, ppc64le, or aarch64 hosts.")
return() return()
elseif (NOT LIBOMPTARGET_DEP_LIBELF_FOUND) elseif (NOT LIBOMPTARGET_DEP_LIBELF_FOUND)
libomptarget_say("Not building CUDA offloading plugin: libelf dependency not found.") libomptarget_say("Not building CUDA offloading plugin: libelf dependency not found.")
return() return()
elseif(NOT LIBOMPTARGET_DEP_CUDA_FOUND) elseif(NOT LIBOMPTARGET_DEP_CUDA_FOUND)
libomptarget_say("Not building CUDA offloading plugin: CUDA not found in system.") libomptarget_say("Not building CUDA offloading plugin: CUDA not found in system.")
return() return()
elseif(NOT LIBOMPTARGET_DEP_CUDA_DRIVER_FOUND) elseif(NOT LIBOMPTARGET_DEP_CUDA_DRIVER_FOUND)
Show All 24 Lines