Details
Details
- Reviewers
atanasyan - Commits
- rG73b1da160513: [MIPS] Implement MIPS3D vector instructions
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Some post commit remarks.
llvm/lib/Target/Mips/MipsInstrFPU.td | ||
---|---|---|
75 | Nit: I think this should be HasMips3D. | |
llvm/lib/Target/Mips/MipsScheduleP5600.td | ||
23 | This should include the HasMips3D predicate so that the CompleteModel check passes.. | |
461 | This addition looks incorrect. Looking at the MIPS32® P5600 Multiprocessing System Software User’s Manual, Revision 01.60, on page 646, it says that wired paired single is not available on the P5600. |
Nit: I think this should be HasMips3D.