Page MenuHomePhabricator

[libc++abi] NFC: Move AtomicInt to cxa_guard_impl.h
ClosedPublic

Authored by ldionne on Mar 10 2020, 10:54 AM.

Details

Summary

Since the atomic_support.h header of libc++abi is considered technical
debt (since we should use libc++'s), it's better not to add new
definitions to it, which makes it diverge from the original libc++
header even more.

Diff Detail

Event Timeline

ldionne created this revision.Mar 10 2020, 10:54 AM
EricWF accepted this revision.Mar 11 2020, 3:41 PM

Is this just a clean move, or is the class definition changed as well?
I can't tell with all the linter warnings in the way.

If it's just a move, this LGTM.

This revision is now accepted and ready to land.Mar 11 2020, 3:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 11 2020, 3:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
This revision now requires review to proceed.Mar 11 2020, 3:41 PM
EricWF accepted this revision.Mar 11 2020, 3:41 PM
This revision is now accepted and ready to land.Mar 11 2020, 3:41 PM

Is this just a clean move, or is the class definition changed as well?
I can't tell with all the linter warnings in the way.

If it's just a move, this LGTM.

It's just a clean move!

This revision was automatically updated to reflect the committed changes.