This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix scheduling info for terminator SALU instructions
ClosedPublic

Authored by foad on Mar 9 2020, 9:49 AM.

Details

Summary

Instruction variants like S_MOV_B32_term should have the same SchedRW
class as the base instruction, S_MOV_B32. This probably doesn't make any
difference in practice because as terminators, they'll always be
scheduled at the end of a basic block, but it's simply more correct than
giving them all the default SchedRW class of Write32Bit, which implies a
VALU operation.

Diff Detail

Event Timeline

foad created this revision.Mar 9 2020, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2020, 9:49 AM
arsenm accepted this revision.Mar 9 2020, 10:23 AM
This revision is now accepted and ready to land.Mar 9 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.