Page MenuHomePhabricator

[CMake] Delete HAVE_ISATTY
AbandonedPublic

Authored by MaskRay on Mar 5 2020, 1:27 PM.

Details

Summary

unistd.h provides isatty. It is provided by 4.3BSD and SVR4, and is
required by POSIX.1-2001. If an old commercial UNIX indeed screw it up,
its libc must lack enough utilities to build LLVM. We should not support
such an ancient system.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 5 2020, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2020, 1:27 PM
dgg5503 added a subscriber: dgg5503.Mar 6 2020, 8:49 AM

isatty() is not supported on the PS4 console OS. We'd like to be able to run some LLVM libraries there, e.g., to support symbolization in compiler-rt on the device. D75278 is a step toward that goal, which I don't think is too unreasonable.
I wonder if other small/embedded devices would have similar restrictions e.g. a watch. Add @aprantl for an opinion.

I'd rather you did not do this.

While I don't think that this is a concern for Darwin-based systems, since the PS4 is a supported LLVM target, that should be enough reason to keep it in, right?

And we could comment that it is needed for the PS4 target specifically to avoid this coming up in the future :-)

MaskRay abandoned this revision.Mar 6 2020, 11:17 AM

Abandoning. See my comment at https://reviews.llvm.org/D75278#1910158