Page MenuHomePhabricator

dgg5503 (Douglas Gliner)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2018, 11:45 AM (102 w, 6 d)

Recent Activity

Tue, Aug 4

dgg5503 added a comment to D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist.
In D84808#2194844, @kcc wrote:

From the description:

this PR adds automatic directory creation for locations in which libFuzzer expects to write data.

I'd prefer libFuzzer to not create directories, but instead err-and-exit if those don't exist.

Tue, Aug 4, 6:42 PM · Restricted Project
dgg5503 added a comment to D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist.
In D84808#2194438, @kcc wrote:

I'd rather fail instead of silently creating new dirs, to be consistent with the other behavior

Tue, Aug 4, 3:45 PM · Restricted Project
dgg5503 added a comment to D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist.

Ping.

Tue, Aug 4, 10:52 AM · Restricted Project

Tue, Jul 28

dgg5503 updated the diff for D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist.

Applied clang-format to some areas of the code but left others alone to be consistent with the rest of the libFuzzer code base. Please let me know if it's appropriate to apply all suggested clang-tidy and clang-format changes.

Tue, Jul 28, 5:01 PM · Restricted Project
dgg5503 added a reviewer for D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist: filcab.
Tue, Jul 28, 4:07 PM · Restricted Project
dgg5503 requested review of D84808: [libFuzzer] Create user supplied fuzzer writeable directories if they don't exist.
Tue, Jul 28, 4:06 PM · Restricted Project

Jun 22 2020

dgg5503 added a comment to D79280: Add option to symbolize inline frames for InternalSymbolizer.

Thanks for the review & approval @vitalybuka! Before I request someone to commit this patch, can you please take a look at my response to your concern regarding the changes made to __sanitizer_symbolize_code?

Jun 22 2020, 12:54 PM · Restricted Project

Jun 4 2020

dgg5503 added a comment to D79280: Add option to symbolize inline frames for InternalSymbolizer.

These tests makes me think that maybe our bot is not running what is expected. I'll check.

Jun 4 2020, 9:53 AM · Restricted Project

May 19 2020

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

May 19 2020, 9:16 AM · Restricted Project, Restricted Project

May 12 2020

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka thanks for the approval! Can someone with commit access please push these changes?

May 12 2020, 11:48 AM · Restricted Project, Restricted Project
dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Added spaces around "&&".

May 12 2020, 11:48 AM · Restricted Project, Restricted Project

May 5 2020

dgg5503 added a comment to D79280: Add option to symbolize inline frames for InternalSymbolizer.

How are those tests are broken? We run InternalSymbolizer on the http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux

May 5 2020, 11:53 AM · Restricted Project

May 4 2020

dgg5503 added a reviewer for D79280: Add option to symbolize inline frames for InternalSymbolizer: filcab.
May 4 2020, 12:54 PM · Restricted Project
dgg5503 updated the diff for D79280: Add option to symbolize inline frames for InternalSymbolizer.

Ran git-clang-format HEAD to resolve CI errors.

May 4 2020, 9:39 AM · Restricted Project

May 1 2020

dgg5503 added inline comments to D79280: Add option to symbolize inline frames for InternalSymbolizer.
May 1 2020, 6:25 PM · Restricted Project
dgg5503 created D79280: Add option to symbolize inline frames for InternalSymbolizer.
May 1 2020, 6:25 PM · Restricted Project
dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Require little-endian byte order when executing tests which read in byte order sensitive .sancov files. This should prevent LIT test failure on big-endian systems such as s390x which is what caused this commit to be reverted as per https://reviews.llvm.org/rL374636.

May 1 2020, 5:11 PM · Restricted Project, Restricted Project

Mar 16 2020

dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

@MaskRay sure.
Name: Douglas Gliner
E-mail:

Mar 16 2020, 5:31 PM · Restricted Project
dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

@MaskRay, is my updated description okay? If so, can someone with commit access please push this change?

Mar 16 2020, 4:24 PM · Restricted Project

Mar 9 2020

dgg5503 updated the summary of D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.
Mar 9 2020, 6:54 PM · Restricted Project
dgg5503 updated the summary of D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.
Mar 9 2020, 5:17 PM · Restricted Project
dgg5503 updated the diff for D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.
Mar 9 2020, 1:30 PM · Restricted Project
dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

@MaskRay thanks for the approval. I just want to make sure you saw my earlier question since I haven't yet updated the description or added a comment:

Mar 9 2020, 1:30 PM · Restricted Project
dgg5503 updated the diff for D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

Changed sys::Process::FileDescriptorIsDisplayed(FD) to raw_fd_ostream::is_displayed().

Mar 9 2020, 11:19 AM · Restricted Project

Mar 6 2020

dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

@MaskRay thanks for the feedback. Before I update the summary and code with a comment, I'd like to first confirm that from our discussion about this function, are Windows, Minix, and fully POSIX compliant OS the only hosts supported by LLVM so far?

Mar 6 2020, 2:55 PM · Restricted Project

Mar 5 2020

dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

At the least, the target OS should be mentioned.

Mar 5 2020, 4:58 PM · Restricted Project
dgg5503 added a comment to D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.

Ping.

Mar 5 2020, 9:17 AM · Restricted Project

Mar 4 2020

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

So I've finally taken the time to figure out why these tests fail on s390x using QEMU. When .sancov files are loaded into memory and the header is checked in isCoverageFile, the check fails presumably due to endianess. For example, the sancov header magic for test-linux_x86_64.0.sancov is expected to be 0xC0BFFFFF but is read as ‭0xFFFFBFC0‬ on big endian systems. I assume the same issue is causing the tests to fail when ran on ppc64be. I am not at all familiar with how other parts of LLVM handle endian differences when reading files from memory using MemoryBuffer::getFile or equivalent. I'd guess there'd be a portable method since llvm-objdump -d /test/tools/sancov/Inputs/test-linux_x86_64 returns the identical output when ran on both s390x and x86_64, but perhaps there are other factors in play that I'm overlooking. What are the expectations regarding cross platform compatibility with sancov? Is it reasonable to expect sancov to be able to parse and provide coverage information for any .sancov and binary compiled for a target supported by LLVM on any platform? Or should users be expected to use .sancov files on the same host that generated them?

Mar 4 2020, 12:56 PM · Restricted Project, Restricted Project

Feb 27 2020

dgg5503 added a reviewer for D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library: chandlerc.
Feb 27 2020, 5:23 PM · Restricted Project
dgg5503 created D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library.
Feb 27 2020, 11:35 AM · Restricted Project

Oct 15 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka I plan to debug this failure as soon as I can. I imagine I'd have to use QEmu to emulate ppc64/s390x since I don't have such a machine on hand. Thanks for committing my other diff though!

Oct 15 2019, 10:48 AM · Restricted Project, Restricted Project

Oct 10 2019

dgg5503 added a comment to D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
In D68752#1705235, @kcc wrote:

I was actually hoping to get rid of this code entirely.
Why do you need this change?

Hi @kcc,

Oct 10 2019, 6:54 PM · Restricted Project, Restricted Project

Oct 9 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka thanks for the explanation. I believe I did it correctly, please let me know otherwise. It is my first time submitting a change to the LLVM project!

Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Split out JSON changes to D68752.

Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 created D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 9 2019, 6:04 PM · Restricted Project, Restricted Project
dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

Oct 9 2019, 3:14 PM · Restricted Project, Restricted Project

Oct 8 2019

dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

Oct 8 2019, 7:00 PM · Restricted Project, Restricted Project
dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Oct 8 2019, 11:44 AM · Restricted Project, Restricted Project

Sep 30 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 30 2019, 12:57 PM · Restricted Project, Restricted Project

Sep 23 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 23 2019, 9:03 AM · Restricted Project, Restricted Project

Sep 16 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 16 2019, 9:07 AM · Restricted Project, Restricted Project

Sep 9 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 9 2019, 9:16 AM · Restricted Project, Restricted Project

Sep 3 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 3 2019, 1:26 PM · Restricted Project, Restricted Project

Aug 26 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 26 2019, 9:20 AM · Restricted Project, Restricted Project

Aug 19 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 19 2019, 10:08 AM · Restricted Project, Restricted Project

Aug 16 2019

dgg5503 added a reviewer for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows: phosek.
Aug 16 2019, 4:40 PM · Restricted Project, Restricted Project
dgg5503 added a reviewer for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows: filcab.
Aug 16 2019, 4:37 PM · Restricted Project, Restricted Project

Aug 12 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 12 2019, 9:39 AM · Restricted Project, Restricted Project

Aug 5 2019

dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Rebase over mono-repo.

Aug 5 2019, 10:25 AM · Restricted Project, Restricted Project

Aug 20 2018

dgg5503 created D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Aug 20 2018, 5:27 PM · Restricted Project, Restricted Project