[mlir][LLVM] Remove pessimizing std::move.

[herhut]

This is to make this build with less permissive warning/error flags, as well :)

[dblaikie]

Just a quick note - PHabricator has a bug where it doesn't send email when status changes are made without text. @ftynse please include some text when approving patches to ensure that approval is reflected on the mailing list as well.

[mehdi_amini]

In D75684#1942146, @dblaikie wrote:

Just a quick note - PHabricator has a bug where it doesn't send email when status changes are made without text. @ftynse please include some text when approving patches to ensure that approval is reflected on the mailing list as well.

I received an email on the approval, can you clarify?

[dblaikie]

In D75684#1942522, @mehdi_amini wrote:

In D75684#1942146, @dblaikie wrote:

Just a quick note - PHabricator has a bug where it doesn't send email when status changes are made without text. @ftynse please include some text when approving patches to ensure that approval is reflected on the mailing list as well.

I received an email on the approval, can you clarify?

Ah, guess it might send it specifically to the author only, then?

But it doesn't seem to make it to the mailing list: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200302/thread.html#751858

[mehdi_amini]

In D75684#1944248, @dblaikie wrote:

I received an email on the approval, can you clarify?

Ah, guess it might send it specifically to the author only, then?

I am only subscriber on this revision, just like the mailing list actually I think.

But it doesn't seem to make it to the mailing list: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200302/thread.html#751858

Our comments (mine and yours) above haven't ended up on the list either apparently, something else must be going on...

[dblaikie]

In D75684#1946846, @mehdi_amini wrote:

In D75684#1944248, @dblaikie wrote:

I received an email on the approval, can you clarify?

Ah, guess it might send it specifically to the author only, then?

I am only subscriber on this revision, just like the mailing list actually I think.

But it doesn't seem to make it to the mailing list: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200302/thread.html#751858

Our comments (mine and yours) above haven't ended up on the list either apparently,

They're on the list, but the way the list archive works is on a per-week basis, so our recent posts to this review are here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200323/759235.html

something else must be going on...

I'm pretty sure it's as I've described it - this isn't the only thread with the problem (check my recent posts to the mailing list as I've flagged a bunch of reviews/reviewers about this & check how they appear in your mail client, examples include: D76935, D74934, D75558, D76189 to name a few)

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

if (auto addressOfOp = dyn_cast<LLVM::AddressOfOp>(opInst)) {
     assert(global && "referencing an undefined global");
 
     valueMapping[addressOfOp.getResult()] = globalsMapping.lookup(global);
     return success();
   }
 
   if (opInst.getDialect() == ompDialect) {
     if (!ompBuilder) {
-      ompBuilder =
-          std::move(std::make_unique<llvm::OpenMPIRBuilder>(*llvmModule));
+      ompBuilder = std::make_unique<llvm::OpenMPIRBuilder>(*llvmModule);
       ompBuilder->initialize();
     }
 
     if (isa<omp::BarrierOp>(opInst)) {
       ompBuilder->CreateBarrier(builder.saveIP(), llvm::omp::OMPD_barrier);
       return success();
     }
     return opInst.emitError("unsupported OpenMP operation: ")