This is an archive of the discontinued LLVM Phabricator instance.

Differential D75494

[PowerPC] Delete PPCMachObjectWriter and triple for darwin
ClosedPublic

Authored by MaskRay on Mar 2 2020, 5:11 PM.

Details

Reviewers
sfertile
jasonliu
Group Reviewers
Restricted Project
Commits
rG3e851f4a688c: [PowerPC] Delete PPCMachObjectWriter and powerpc{,64}-apple-darwin

Diff Detail

Event Timeline

MaskRay created this revision.Mar 2 2020, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2020, 5:11 PM
Herald added subscribers: llvm-commits, shchenz, jsji and 4 others. · View Herald Transcript
Harbormaster failed remote builds in B47846: Diff 247765!Mar 2 2020, 6:04 PM
Herald added a subscriber: • wuzish. · View Herald TranscriptMar 2 2020, 6:04 PM
MaskRay updated this revision to Diff 247784.Mar 2 2020, 9:15 PM

Fix tests

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2020, 9:15 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B47856: Diff 247784.Mar 2 2020, 9:48 PM
sfertile accepted this revision.Mar 5 2020, 9:58 AM

LGTM.

This revision is now accepted and ready to land.Mar 5 2020, 9:58 AM
Closed by commit rG3e851f4a688c: [PowerPC] Delete PPCMachObjectWriter and powerpc{,64}-apple-darwin (authored by MaskRay). · Explain WhyMar 5 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.
MaskRay mentioned this in D91836: [PowerPC] Delete remnant Darwin code in PPCAsmParser.Nov 19 2020, 5:50 PM
MaskRay mentioned this in rG7c4555f60d96: [PowerPC] Delete remnant Darwin code in PPCAsmParser.Nov 30 2020, 10:16 AM
MaskRay mentioned this in rG9f77facfce3c: [Driver] Properly report error for unsupported powerpc darwin/macos triples.Sep 10 2023, 7:09 PM
MaskRay mentioned this in rG2bdf5aa5dfff: [Driver] Properly report error for unsupported powerpc darwin/macos triples.Sep 11 2023, 6:54 PM

Revision Contents

PathSize
clang/
test/
Driver/
28 lines
Tooling/
4 lines
llvm/
lib/
Support/
4 lines
Target/
PowerPC/
MCTargetDesc/
1 line
16 lines
unittests/
BinaryFormat/
4 lines
utils/
gn/
secondary/
llvm/
lib/
Target/
PowerPC/
MCTargetDesc/
1 line

Diff 247784

clang/test/Driver/darwin-arch-default.c

  • This file was deleted.
// Check that the name of the arch we bind is "ppc" not "powerpc".
//
// RUN: %clang -target powerpc-apple-darwin8 -### \
// RUN: -ccc-print-phases %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-BIND-PPC < %t %s
//
// CHECK-BIND-PPC: bind-arch, "ppc"
//
// RUN: %clang -target powerpc64-apple-darwin8 -### \
// RUN: -ccc-print-phases %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-BIND-PPC64 < %t %s
//
// CHECK-BIND-PPC64: bind-arch, "ppc64"
// Check that the correct arch name is passed to the external assembler
//
// RUN: %clang -target powerpc-apple-darwin8 -### \
// RUN: -no-integrated-as -c %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-AS-PPC < %t %s
//
// CHECK-AS-PPC: {{as(.exe)?"}}
// CHECK-AS-PPC: "-arch" "ppc"
//
// RUN: %clang -target powerpc64-apple-darwin8 -### \
// RUN: -no-integrated-as -c %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-AS-PPC64 < %t %s
//
// CHECK-AS-PPC64: {{as(.exe)?"}}
// CHECK-AS-PPC64: "-arch" "ppc64"
// Check that the correct arch name is passed to the external linker
//
// RUN: %clang -target powerpc-apple-darwin8 -### %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-LD-PPC < %t %s
//
// CHECK-LD-PPC: {{ld(.exe)?"}}
// CHECK-LD-PPC: "-arch" "ppc"
//
// RUN: %clang -target powerpc64-apple-darwin8 -### %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-LD-PPC64 < %t %s
//
// CHECK-LD-PPC64: {{ld(.exe)?"}}
// CHECK-LD-PPC64: "-arch" "ppc64"

clang/test/Driver/darwin-header-search-libstdcxx.cpp

// UNSUPPORTED: system-windows // UNSUPPORTED: system-windows
// General tests that the header search paths for libstdc++ detected by the // General tests that the header search paths for libstdc++ detected by the
// driver and passed to CC1 are correct on Darwin platforms. // driver and passed to CC1 are correct on Darwin platforms.
// Check ppc and ppc64
//
// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \
// RUN: -target ppc-apple-darwin \
// RUN: -stdlib=libstdc++ \
// RUN: -isysroot %S/Inputs/basic_darwin_sdk_libstdcxx_ppc \
// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_libstdcxx_ppc --check-prefix=CHECK-LIBSTDCXX-PPC %s
// CHECK-LIBSTDCXX-PPC: "{{[^"]*}}clang{{[^"]*}}" "-cc1"
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1/powerpc-apple-darwin10"
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1/backward"
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0"
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0/powerpc-apple-darwin10"
// CHECK-LIBSTDCXX-PPC: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0/backward"
//
// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \
// RUN: -target ppc64-apple-darwin \
// RUN: -stdlib=libstdc++ \
// RUN: -isysroot %S/Inputs/basic_darwin_sdk_libstdcxx_ppc \
// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_libstdcxx_ppc --check-prefix=CHECK-LIBSTDCXX-PPC64 %s
// CHECK-LIBSTDCXX-PPC64: "{{[^"]*}}clang{{[^"]*}}" "-cc1"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1/powerpc-apple-darwin10/ppc64"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.2.1/backward"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0/powerpc-apple-darwin10/ppc64"
// CHECK-LIBSTDCXX-PPC64: "-internal-isystem" "[[SYSROOT]]/usr/include/c++/4.0.0/backward"
// Check x86 and x86_64 // Check x86 and x86_64
// //
// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \ // RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \
// RUN: -target i686-apple-darwin \ // RUN: -target i686-apple-darwin \
// RUN: -stdlib=libstdc++ \ // RUN: -stdlib=libstdc++ \
// RUN: -isysroot %S/Inputs/basic_darwin_sdk_libstdcxx_x86 \ // RUN: -isysroot %S/Inputs/basic_darwin_sdk_libstdcxx_x86 \
// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_libstdcxx_x86 --check-prefix=CHECK-LIBSTDCXX-X86 %s // RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_libstdcxx_x86 --check-prefix=CHECK-LIBSTDCXX-X86 %s
// CHECK-LIBSTDCXX-X86: "{{[^"]*}}clang{{[^"]*}}" "-cc1" // CHECK-LIBSTDCXX-X86: "{{[^"]*}}clang{{[^"]*}}" "-cc1"
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines

clang/test/Tooling/ms-asm-no-target.cpp

// RUN: clang-check "%s" -- -fasm-blocks -target x86_64-apple-darwin10 2>&1 | FileCheck -check-prefix=CHECK-X86 %s -allow-empty // RUN: clang-check "%s" -- -fasm-blocks -target x86_64-apple-darwin10 2>&1 | FileCheck -check-prefix=CHECK-X86 %s -allow-empty
// RUN: not clang-check "%s" -- -fasm-blocks -target powerpc-apple-darwin10 2>&1 | FileCheck -check-prefix=CHECK-PPC %s
// REQUIRES: x86-registered-target // REQUIRES: x86-registered-target
void Break() { void Break() {
__asm { int 3 } __asm { int 3 }
} }
// clang-check should initialize the x86 target, so x86 should work. // clang-check should initialize the x86 target, so x86 should work.
// CHECK-X86-NOT: error: MS-style inline assembly is not available // CHECK-X86-NOT: error: MS-style inline assembly is not available
// Test that the ordinary error is emitted on unsupported architectures.
// CHECK-PPC: error: Unsupported architecture 'powerpc' for MS-style inline assembly

llvm/lib/Support/Triple.cpp

Show First 20 Lines • Show All 706 Lines • ▼ Show 20 Linesstatic Triple::ObjectFormatType getDefaultFormat(const Triple &T) {
case Triple::tcele: case Triple::tcele:
case Triple::thumbeb: case Triple::thumbeb:
case Triple::ve: case Triple::ve:
case Triple::xcore: case Triple::xcore:
return Triple::ELF; return Triple::ELF;
case Triple::ppc64: case Triple::ppc64:
case Triple::ppc: case Triple::ppc:
if (T.isOSDarwin()) if (T.isOSAIX())
return Triple::MachO;
else if (T.isOSAIX())
return Triple::XCOFF; return Triple::XCOFF;
return Triple::ELF; return Triple::ELF;
case Triple::wasm32: case Triple::wasm32:
case Triple::wasm64: case Triple::wasm64:
return Triple::Wasm; return Triple::Wasm;
} }
llvm_unreachable("unknown architecture"); llvm_unreachable("unknown architecture");
▲ Show 20 Lines • Show All 943 Lines • Show Last 20 Lines

llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt

add_llvm_component_library(LLVMPowerPCDesc add_llvm_component_library(LLVMPowerPCDesc
PPCAsmBackend.cpp PPCAsmBackend.cpp
PPCInstPrinter.cpp PPCInstPrinter.cpp
PPCMCTargetDesc.cpp PPCMCTargetDesc.cpp
PPCMCAsmInfo.cpp PPCMCAsmInfo.cpp
PPCMCCodeEmitter.cpp PPCMCCodeEmitter.cpp
PPCMCExpr.cpp PPCMCExpr.cpp
PPCPredicates.cpp PPCPredicates.cpp
PPCMachObjectWriter.cpp
PPCELFObjectWriter.cpp PPCELFObjectWriter.cpp
PPCXCOFFObjectWriter.cpp PPCXCOFFObjectWriter.cpp
PPCELFStreamer.cpp PPCELFStreamer.cpp
) )

llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp

Show First 20 Lines • Show All 194 Lines • ▼ Show 20 Linespublic:
} }
}; };
} // end anonymous namespace } // end anonymous namespace
// FIXME: This should be in a separate file. // FIXME: This should be in a separate file.
namespace { namespace {
class DarwinPPCAsmBackend : public PPCAsmBackend {
public:
DarwinPPCAsmBackend(const Target &T, const Triple &TT)
: PPCAsmBackend(T, TT) {}
std::unique_ptr<MCObjectTargetWriter>
createObjectTargetWriter() const override {
uint32_t CPUType = cantFail(MachO::getCPUType(TT));
uint32_t CPUSubType = cantFail(MachO::getCPUSubType(TT));
return createPPCMachObjectWriter(TT.isArch64Bit(), CPUType, CPUSubType);
}
};
class ELFPPCAsmBackend : public PPCAsmBackend { class ELFPPCAsmBackend : public PPCAsmBackend {
public: public:
ELFPPCAsmBackend(const Target &T, const Triple &TT) : PPCAsmBackend(T, TT) {} ELFPPCAsmBackend(const Target &T, const Triple &TT) : PPCAsmBackend(T, TT) {}
std::unique_ptr<MCObjectTargetWriter> std::unique_ptr<MCObjectTargetWriter>
createObjectTargetWriter() const override { createObjectTargetWriter() const override {
uint8_t OSABI = MCELFObjectTargetWriter::getOSABI(TT.getOS()); uint8_t OSABI = MCELFObjectTargetWriter::getOSABI(TT.getOS());
bool Is64 = TT.isPPC64(); bool Is64 = TT.isPPC64();
Show All 27 LinesOptional<MCFixupKind> ELFPPCAsmBackend::getFixupKind(StringRef Name) const {
return MCAsmBackend::getFixupKind(Name); return MCAsmBackend::getFixupKind(Name);
} }
MCAsmBackend *llvm::createPPCAsmBackend(const Target &T, MCAsmBackend *llvm::createPPCAsmBackend(const Target &T,
const MCSubtargetInfo &STI, const MCSubtargetInfo &STI,
const MCRegisterInfo &MRI, const MCRegisterInfo &MRI,
const MCTargetOptions &Options) { const MCTargetOptions &Options) {
const Triple &TT = STI.getTargetTriple(); const Triple &TT = STI.getTargetTriple();
if (TT.isOSDarwin())
return new DarwinPPCAsmBackend(T, TT);
if (TT.isOSBinFormatXCOFF()) if (TT.isOSBinFormatXCOFF())
return new XCOFFPPCAsmBackend(T, TT); return new XCOFFPPCAsmBackend(T, TT);
return new ELFPPCAsmBackend(T, TT); return new ELFPPCAsmBackend(T, TT);
} }

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMachObjectWriter.cpp

  • This file was deleted.
//===-- PPCMachObjectWriter.cpp - PPC Mach-O Writer -----------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "MCTargetDesc/PPCFixupKinds.h"
#include "MCTargetDesc/PPCMCTargetDesc.h"
#include "llvm/ADT/Twine.h"
#include "llvm/BinaryFormat/MachO.h"
#include "llvm/MC/MCAsmLayout.h"
#include "llvm/MC/MCAssembler.h"
#include "llvm/MC/MCContext.h"
#include "llvm/MC/MCMachObjectWriter.h"
#include "llvm/MC/MCSectionMachO.h"
#include "llvm/MC/MCValue.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/Format.h"
using namespace llvm;
namespace {
class PPCMachObjectWriter : public MCMachObjectTargetWriter {
bool recordScatteredRelocation(MachObjectWriter *Writer,
const MCAssembler &Asm,
const MCAsmLayout &Layout,
const MCFragment *Fragment,
const MCFixup &Fixup, MCValue Target,
unsigned Log2Size, uint64_t &FixedValue);
void RecordPPCRelocation(MachObjectWriter *Writer, const MCAssembler &Asm,
const MCAsmLayout &Layout,
const MCFragment *Fragment, const MCFixup &Fixup,
MCValue Target, uint64_t &FixedValue);
public:
PPCMachObjectWriter(bool Is64Bit, uint32_t CPUType, uint32_t CPUSubtype)
: MCMachObjectTargetWriter(Is64Bit, CPUType, CPUSubtype) {}
void recordRelocation(MachObjectWriter *Writer, MCAssembler &Asm,
const MCAsmLayout &Layout, const MCFragment *Fragment,
const MCFixup &Fixup, MCValue Target,
uint64_t &FixedValue) override {
if (Writer->is64Bit()) {
report_fatal_error("Relocation emission for MachO/PPC64 unimplemented.");
} else
RecordPPCRelocation(Writer, Asm, Layout, Fragment, Fixup, Target,
FixedValue);
}
};
}
/// computes the log2 of the size of the relocation,
/// used for relocation_info::r_length.
static unsigned getFixupKindLog2Size(unsigned Kind) {
switch (Kind) {
default:
report_fatal_error("log2size(FixupKind): Unhandled fixup kind!");
case FK_PCRel_1:
case FK_Data_1:
return 0;
case FK_PCRel_2:
case FK_Data_2:
return 1;
case FK_PCRel_4:
case PPC::fixup_ppc_brcond14:
case PPC::fixup_ppc_half16:
case PPC::fixup_ppc_br24:
case FK_Data_4:
return 2;
case FK_PCRel_8:
case FK_Data_8:
return 3;
}
return 0;
}
/// Translates generic PPC fixup kind to Mach-O/PPC relocation type enum.
/// Outline based on PPCELFObjectWriter::getRelocType().
static unsigned getRelocType(const MCValue &Target,
const MCFixupKind FixupKind, // from
// Fixup.getKind()
const bool IsPCRel) {
const MCSymbolRefExpr::VariantKind Modifier =
Target.isAbsolute() ? MCSymbolRefExpr::VK_None
: Target.getSymA()->getKind();
// determine the type of the relocation
unsigned Type = MachO::GENERIC_RELOC_VANILLA;
if (IsPCRel) { // relative to PC
switch ((unsigned)FixupKind) {
default:
report_fatal_error("Unimplemented fixup kind (relative)");
case PPC::fixup_ppc_br24:
Type = MachO::PPC_RELOC_BR24; // R_PPC_REL24
break;
case PPC::fixup_ppc_brcond14:
Type = MachO::PPC_RELOC_BR14;
break;
case PPC::fixup_ppc_half16:
switch (Modifier) {
default:
llvm_unreachable("Unsupported modifier for half16 fixup");
case MCSymbolRefExpr::VK_PPC_HA:
Type = MachO::PPC_RELOC_HA16;
break;
case MCSymbolRefExpr::VK_PPC_LO:
Type = MachO::PPC_RELOC_LO16;
break;
case MCSymbolRefExpr::VK_PPC_HI:
Type = MachO::PPC_RELOC_HI16;
break;
}
break;
}
} else {
switch ((unsigned)FixupKind) {
default:
report_fatal_error("Unimplemented fixup kind (absolute)!");
case PPC::fixup_ppc_half16:
switch (Modifier) {
default:
llvm_unreachable("Unsupported modifier for half16 fixup");
case MCSymbolRefExpr::VK_PPC_HA:
Type = MachO::PPC_RELOC_HA16_SECTDIFF;
break;
case MCSymbolRefExpr::VK_PPC_LO:
Type = MachO::PPC_RELOC_LO16_SECTDIFF;
break;
case MCSymbolRefExpr::VK_PPC_HI:
Type = MachO::PPC_RELOC_HI16_SECTDIFF;
break;
}
break;
case FK_Data_4:
break;
case FK_Data_2:
break;
}
}
return Type;
}
static void makeRelocationInfo(MachO::any_relocation_info &MRE,
const uint32_t FixupOffset, const uint32_t Index,
const unsigned IsPCRel, const unsigned Log2Size,
const unsigned IsExtern, const unsigned Type) {
MRE.r_word0 = FixupOffset;
// The bitfield offsets that work (as determined by trial-and-error)
// are different than what is documented in the mach-o manuals.
// This appears to be an endianness issue; reversing the order of the
// documented bitfields in <llvm/BinaryFormat/MachO.h> fixes this (but
// breaks x86/ARM assembly).
MRE.r_word1 = ((Index << 8) | // was << 0
(IsPCRel << 7) | // was << 24
(Log2Size << 5) | // was << 25
(IsExtern << 4) | // was << 27
(Type << 0)); // was << 28
}
static void
makeScatteredRelocationInfo(MachO::any_relocation_info &MRE,
const uint32_t Addr, const unsigned Type,
const unsigned Log2Size, const unsigned IsPCRel,
const uint32_t Value2) {
// For notes on bitfield positions and endianness, see:
// https://developer.apple.com/library/mac/documentation/developertools/conceptual/MachORuntime/Reference/reference.html#//apple_ref/doc/uid/20001298-scattered_relocation_entry
MRE.r_word0 = ((Addr << 0) | (Type << 24) | (Log2Size << 28) |
(IsPCRel << 30) | MachO::R_SCATTERED);
MRE.r_word1 = Value2;
}
/// Compute fixup offset (address).
static uint32_t getFixupOffset(const MCAsmLayout &Layout,
const MCFragment *Fragment,
const MCFixup &Fixup) {
uint32_t FixupOffset = Layout.getFragmentOffset(Fragment) + Fixup.getOffset();
// On Mach-O, ppc_fixup_half16 relocations must refer to the
// start of the instruction, not the second halfword, as ELF does
if (Fixup.getTargetKind() == PPC::fixup_ppc_half16)
FixupOffset &= ~uint32_t(3);
return FixupOffset;
}
/// \return false if falling back to using non-scattered relocation,
/// otherwise true for normal scattered relocation.
/// based on X86MachObjectWriter::recordScatteredRelocation
/// and ARMMachObjectWriter::recordScatteredRelocation
bool PPCMachObjectWriter::recordScatteredRelocation(
MachObjectWriter *Writer, const MCAssembler &Asm, const MCAsmLayout &Layout,
const MCFragment *Fragment, const MCFixup &Fixup, MCValue Target,
unsigned Log2Size, uint64_t &FixedValue) {
// caller already computes these, can we just pass and reuse?
const uint32_t FixupOffset = getFixupOffset(Layout, Fragment, Fixup);
const MCFixupKind FK = Fixup.getKind();
const unsigned IsPCRel = Writer->isFixupKindPCRel(Asm, FK);
const unsigned Type = getRelocType(Target, FK, IsPCRel);
// Is this a local or SECTDIFF relocation entry?
// SECTDIFF relocation entries have symbol subtractions,
// and require two entries, the first for the add-symbol value,
// the second for the subtract-symbol value.
// See <reloc.h>.
const MCSymbol *A = &Target.getSymA()->getSymbol();
if (!A->getFragment())
report_fatal_error("symbol '" + A->getName() +
"' can not be undefined in a subtraction expression");
uint32_t Value = Writer->getSymbolAddress(*A, Layout);
uint64_t SecAddr = Writer->getSectionAddress(A->getFragment()->getParent());
FixedValue += SecAddr;
uint32_t Value2 = 0;
if (const MCSymbolRefExpr *B = Target.getSymB()) {
const MCSymbol *SB = &B->getSymbol();
if (!SB->getFragment())
report_fatal_error("symbol '" + SB->getName() +
"' can not be undefined in a subtraction expression");
// FIXME: is Type correct? see include/llvm/BinaryFormat/MachO.h
Value2 = Writer->getSymbolAddress(*SB, Layout);
FixedValue -= Writer->getSectionAddress(SB->getFragment()->getParent());
}
// FIXME: does FixedValue get used??
// Relocations are written out in reverse order, so the PAIR comes first.
if (Type == MachO::PPC_RELOC_SECTDIFF ||
Type == MachO::PPC_RELOC_HI16_SECTDIFF ||
Type == MachO::PPC_RELOC_LO16_SECTDIFF ||
Type == MachO::PPC_RELOC_HA16_SECTDIFF ||
Type == MachO::PPC_RELOC_LO14_SECTDIFF ||
Type == MachO::PPC_RELOC_LOCAL_SECTDIFF) {
// X86 had this piece, but ARM does not
// If the offset is too large to fit in a scattered relocation,
// we're hosed. It's an unfortunate limitation of the MachO format.
if (FixupOffset > 0xffffff) {
char Buffer[32];
format("0x%x", FixupOffset).print(Buffer, sizeof(Buffer));
Asm.getContext().reportError(Fixup.getLoc(),
Twine("Section too large, can't encode "
"r_address (") +
Buffer + ") into 24 bits of scattered "
"relocation entry.");
return false;
}
// Is this supposed to follow MCTarget/PPCAsmBackend.cpp:adjustFixupValue()?
// see PPCMCExpr::evaluateAsRelocatableImpl()
uint32_t other_half = 0;
switch (Type) {
case MachO::PPC_RELOC_LO16_SECTDIFF:
other_half = (FixedValue >> 16) & 0xffff;
// applyFixupOffset longer extracts the high part because it now assumes
// this was already done.
// It looks like this is not true for the FixedValue needed with Mach-O
// relocs.
// So we need to adjust FixedValue again here.
FixedValue &= 0xffff;
break;
case MachO::PPC_RELOC_HA16_SECTDIFF:
other_half = FixedValue & 0xffff;
FixedValue =
((FixedValue >> 16) + ((FixedValue & 0x8000) ? 1 : 0)) & 0xffff;
break;
case MachO::PPC_RELOC_HI16_SECTDIFF:
other_half = FixedValue & 0xffff;
FixedValue = (FixedValue >> 16) & 0xffff;
break;
default:
llvm_unreachable("Invalid PPC scattered relocation type.");
break;
}
MachO::any_relocation_info MRE;
makeScatteredRelocationInfo(MRE, other_half, MachO::GENERIC_RELOC_PAIR,
Log2Size, IsPCRel, Value2);
Writer->addRelocation(nullptr, Fragment->getParent(), MRE);
} else {
// If the offset is more than 24-bits, it won't fit in a scattered
// relocation offset field, so we fall back to using a non-scattered
// relocation. This is a bit risky, as if the offset reaches out of
// the block and the linker is doing scattered loading on this
// symbol, things can go badly.
//
// Required for 'as' compatibility.
if (FixupOffset > 0xffffff)
return false;
}
MachO::any_relocation_info MRE;
makeScatteredRelocationInfo(MRE, FixupOffset, Type, Log2Size, IsPCRel, Value);
Writer->addRelocation(nullptr, Fragment->getParent(), MRE);
return true;
}
// see PPCELFObjectWriter for a general outline of cases
void PPCMachObjectWriter::RecordPPCRelocation(
MachObjectWriter *Writer, const MCAssembler &Asm, const MCAsmLayout &Layout,
const MCFragment *Fragment, const MCFixup &Fixup, MCValue Target,
uint64_t &FixedValue) {
const MCFixupKind FK = Fixup.getKind(); // unsigned
const unsigned Log2Size = getFixupKindLog2Size(FK);
const bool IsPCRel = Writer->isFixupKindPCRel(Asm, FK);
const unsigned RelocType = getRelocType(Target, FK, IsPCRel);
// If this is a difference or a defined symbol plus an offset, then we need a
// scattered relocation entry. Differences always require scattered
// relocations.
if (Target.getSymB() &&
// Q: are branch targets ever scattered?
RelocType != MachO::PPC_RELOC_BR24 &&
RelocType != MachO::PPC_RELOC_BR14) {
recordScatteredRelocation(Writer, Asm, Layout, Fragment, Fixup, Target,
Log2Size, FixedValue);
return;
}
// this doesn't seem right for RIT_PPC_BR24
// Get the symbol data, if any.
const MCSymbol *A = nullptr;
if (Target.getSymA())
A = &Target.getSymA()->getSymbol();
// See <reloc.h>.
const uint32_t FixupOffset = getFixupOffset(Layout, Fragment, Fixup);
unsigned Index = 0;
unsigned Type = RelocType;
const MCSymbol *RelSymbol = nullptr;
if (Target.isAbsolute()) { // constant
// SymbolNum of 0 indicates the absolute section.
//
// FIXME: Currently, these are never generated (see code below). I cannot
// find a case where they are actually emitted.
report_fatal_error("FIXME: relocations to absolute targets "
"not yet implemented");
// the above line stolen from ARM, not sure
} else {
// Resolve constant variables.
if (A->isVariable()) {
int64_t Res;
if (A->getVariableValue()->evaluateAsAbsolute(
Res, Layout, Writer->getSectionAddressMap())) {
FixedValue = Res;
return;
}
}
// Check whether we need an external or internal relocation.
if (Writer->doesSymbolRequireExternRelocation(*A)) {
RelSymbol = A;
// For external relocations, make sure to offset the fixup value to
// compensate for the addend of the symbol address, if it was
// undefined. This occurs with weak definitions, for example.
if (!A->isUndefined())
FixedValue -= Layout.getSymbolOffset(*A);
} else {
// The index is the section ordinal (1-based).
const MCSection &Sec = A->getSection();
Index = Sec.getOrdinal() + 1;
FixedValue += Writer->getSectionAddress(&Sec);
}
if (IsPCRel)
FixedValue -= Writer->getSectionAddress(Fragment->getParent());
}
// struct relocation_info (8 bytes)
MachO::any_relocation_info MRE;
makeRelocationInfo(MRE, FixupOffset, Index, IsPCRel, Log2Size, false, Type);
Writer->addRelocation(RelSymbol, Fragment->getParent(), MRE);
}
std::unique_ptr<MCObjectTargetWriter>
llvm::createPPCMachObjectWriter(bool Is64Bit, uint32_t CPUType,
uint32_t CPUSubtype) {
return std::make_unique<PPCMachObjectWriter>(Is64Bit, CPUType, CPUSubtype);
}

llvm/unittests/BinaryFormat/MachOTest.cpp

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines#define CHECK_CPUTYPE(StrTriple, ExpectedCPUType) \
CHECK_CPUTYPE("x86_64-apple-darwin", MachO::CPU_TYPE_X86_64); CHECK_CPUTYPE("x86_64-apple-darwin", MachO::CPU_TYPE_X86_64);
CHECK_CPUTYPE("x86_64h-apple-darwin", MachO::CPU_TYPE_X86_64); CHECK_CPUTYPE("x86_64h-apple-darwin", MachO::CPU_TYPE_X86_64);
CHECK_CPUTYPE("i386-apple-darwin", MachO::CPU_TYPE_X86); CHECK_CPUTYPE("i386-apple-darwin", MachO::CPU_TYPE_X86);
CHECK_CPUTYPE("armv7-apple-darwin", MachO::CPU_TYPE_ARM); CHECK_CPUTYPE("armv7-apple-darwin", MachO::CPU_TYPE_ARM);
CHECK_CPUTYPE("thumbv7-apple-darwin", MachO::CPU_TYPE_ARM); CHECK_CPUTYPE("thumbv7-apple-darwin", MachO::CPU_TYPE_ARM);
CHECK_CPUTYPE("arm64-apple-darwin", MachO::CPU_TYPE_ARM64); CHECK_CPUTYPE("arm64-apple-darwin", MachO::CPU_TYPE_ARM64);
CHECK_CPUTYPE("arm64e-apple-darwin", MachO::CPU_TYPE_ARM64); CHECK_CPUTYPE("arm64e-apple-darwin", MachO::CPU_TYPE_ARM64);
CHECK_CPUTYPE("arm64_32-apple-darwin", MachO::CPU_TYPE_ARM64_32); CHECK_CPUTYPE("arm64_32-apple-darwin", MachO::CPU_TYPE_ARM64_32);
CHECK_CPUTYPE("powerpc-apple-darwin", MachO::CPU_TYPE_POWERPC);
CHECK_CPUTYPE("powerpc64-apple-darwin", MachO::CPU_TYPE_POWERPC64);
{ {
// Not a mach-o. // Not a mach-o.
Expected<uint32_t> Type = MachO::getCPUType(Triple("x86_64-linux-unknown")); Expected<uint32_t> Type = MachO::getCPUType(Triple("x86_64-linux-unknown"));
ASSERT_EQ(toString(Type.takeError()), ASSERT_EQ(toString(Type.takeError()),
"Unsupported triple for mach-o cpu type: x86_64-linux-unknown"); "Unsupported triple for mach-o cpu type: x86_64-linux-unknown");
} }
{ {
Show All 25 Lines#define CHECK_CPUSUBTYPE(StrTriple, ExpectedCPUSubType) \
CHECK_CPUSUBTYPE("armv6m-apple-darwin", MachO::CPU_SUBTYPE_ARM_V6M); CHECK_CPUSUBTYPE("armv6m-apple-darwin", MachO::CPU_SUBTYPE_ARM_V6M);
CHECK_CPUSUBTYPE("armv7m-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7M); CHECK_CPUSUBTYPE("armv7m-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7M);
CHECK_CPUSUBTYPE("armv7em-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7EM); CHECK_CPUSUBTYPE("armv7em-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7EM);
CHECK_CPUSUBTYPE("thumbv7-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7); CHECK_CPUSUBTYPE("thumbv7-apple-darwin", MachO::CPU_SUBTYPE_ARM_V7);
CHECK_CPUSUBTYPE("thumbv6-apple-darwin", MachO::CPU_SUBTYPE_ARM_V6); CHECK_CPUSUBTYPE("thumbv6-apple-darwin", MachO::CPU_SUBTYPE_ARM_V6);
CHECK_CPUSUBTYPE("arm64-apple-darwin", MachO::CPU_SUBTYPE_ARM64_ALL); CHECK_CPUSUBTYPE("arm64-apple-darwin", MachO::CPU_SUBTYPE_ARM64_ALL);
CHECK_CPUSUBTYPE("arm64e-apple-darwin", MachO::CPU_SUBTYPE_ARM64E); CHECK_CPUSUBTYPE("arm64e-apple-darwin", MachO::CPU_SUBTYPE_ARM64E);
CHECK_CPUSUBTYPE("arm64_32-apple-darwin", MachO::CPU_SUBTYPE_ARM64_32_V8); CHECK_CPUSUBTYPE("arm64_32-apple-darwin", MachO::CPU_SUBTYPE_ARM64_32_V8);
CHECK_CPUSUBTYPE("powerpc-apple-darwin", MachO::CPU_SUBTYPE_POWERPC_ALL);
CHECK_CPUSUBTYPE("powerpc64-apple-darwin", MachO::CPU_SUBTYPE_POWERPC_ALL);
{ {
// Not a mach-o. // Not a mach-o.
Expected<uint32_t> Type = Expected<uint32_t> Type =
MachO::getCPUSubType(Triple("x86_64-linux-unknown")); MachO::getCPUSubType(Triple("x86_64-linux-unknown"));
ASSERT_EQ( ASSERT_EQ(
toString(Type.takeError()), toString(Type.takeError()),
"Unsupported triple for mach-o cpu subtype: x86_64-linux-unknown"); "Unsupported triple for mach-o cpu subtype: x86_64-linux-unknown");
Show All 9 Lines

llvm/utils/gn/secondary/llvm/lib/Target/PowerPC/MCTargetDesc/BUILD.gn

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines sources = [
"PPCAsmBackend.cpp", "PPCAsmBackend.cpp",
"PPCELFObjectWriter.cpp", "PPCELFObjectWriter.cpp",
"PPCELFStreamer.cpp", "PPCELFStreamer.cpp",
"PPCInstPrinter.cpp", "PPCInstPrinter.cpp",
"PPCMCAsmInfo.cpp", "PPCMCAsmInfo.cpp",
"PPCMCCodeEmitter.cpp", "PPCMCCodeEmitter.cpp",
"PPCMCExpr.cpp", "PPCMCExpr.cpp",
"PPCMCTargetDesc.cpp", "PPCMCTargetDesc.cpp",
"PPCMachObjectWriter.cpp",
"PPCPredicates.cpp", "PPCPredicates.cpp",
"PPCXCOFFObjectWriter.cpp", "PPCXCOFFObjectWriter.cpp",
] ]
} }
llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp