Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D75317

[mlir] Automatically populate `operand_segment_sizes` in the auto-generated build methods.
ClosedPublic
Actions

Authored by rriddle on Feb 27 2020, 4:44 PM.

Details

Reviewers
antiagainst
nicolasvasilache
jpienaar
Commits
rGc98cff5ae432: [mlir] Automatically populate `operand_segment_sizes` in the auto-generated…
Summary

This greatly simplifies the requirements for builders using this mechanism for managing variadic operands.

Depends On D75316

Diff Detail

Event Timeline

rriddle created this revision.Feb 27 2020, 4:44 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 27 2020, 4:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 8 others. · View Herald Transcript
rriddle added a child revision: D75318: [mlir] Remove successor operands from the Operation class.Feb 27 2020, 4:45 PM
Harbormaster completed remote builds in B47534: Diff 247134.Feb 27 2020, 5:05 PM
jpienaar accepted this revision.Feb 28 2020, 6:02 AM

Nice, thanks

This revision is now accepted and ready to land.Feb 28 2020, 6:02 AM
antiagainst accepted this revision.Feb 28 2020, 4:00 PM

Cool!

rriddle updated this revision to Diff 248580.Mar 5 2020, 12:42 PM

Rebase

Closed by commit rGc98cff5ae432: [mlir] Automatically populate `operand_segment_sizes` in the auto-generated… (authored by rriddle). · Explain WhyMar 5 2020, 1:13 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B48257: Diff 248580.Mar 5 2020, 1:44 PM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
StandardOps/
IR/
5 lines
VectorOps/
3 lines
lib/
Dialect/
StandardOps/
IR/
5 lines
test/
mlir-tblgen/
4 lines
tools/
mlir-tblgen/
19 lines

Diff 248591

View Options

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Loading...
View Options

mlir/include/mlir/Dialect/VectorOps/VectorOps.td

Loading...
View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Loading...
View Options

mlir/test/mlir-tblgen/op-result.td

Loading...
View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...