Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir] Add traits for verifying the number of successors and providing relevant accessors.
ClosedPublic
Actions

Authored by rriddle on Feb 27 2020, 4:42 PM.

Details

Reviewers

mehdi_amini
antiagainst
mravishankar

Commits

rGc0fd5e657e5d: [mlir] Add traits for verifying the number of successors and providing relevant…

Summary

This allows for simplifying OpDefGen, as well providing specializing accessors for the different successor counts. This mirrors the existing traits for operands and results.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Feb 27 2020, 4:42 PM

Herald added a reviewer: mravishankar. · View Herald TranscriptFeb 27 2020, 4:42 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, bader, Joonsoo and 8 others. · View Herald Transcript

rriddle added a child revision: D75314: [mlir] Add a new BranchOpInterface to allow for opaquely interfacing with branching terminator operations..Feb 27 2020, 4:43 PM

Harbormaster failed remote builds in B47530: Diff 247130!Feb 27 2020, 5:14 PM

mravishankar resigned from this revision.Mar 4 2020, 10:27 AM

Nice!

This revision is now accepted and ready to land.Mar 4 2020, 10:48 AM

Fix formatting.

Harbormaster completed remote builds in B48232: Diff 248531.Mar 5 2020, 11:32 AM

Rebase

Closed by commit rGc0fd5e657e5d: [mlir] Add traits for verifying the number of successors and providing relevant… (authored by rriddle). · Explain WhyMar 5 2020, 1:12 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B48253: Diff 248574.Mar 5 2020, 1:44 PM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

OpDefinition.h

162 lines

lib/

Dialect/

SPIRV/

SPIRVOps.cpp

2 lines

StandardOps/

IR/

Ops.cpp

4 lines

IR/

Operation.cpp

48 lines

Target/

LLVMIR/

ModuleTranslation.cpp

2 lines

test/

Dialect/

SPIRV/

control-flow-ops.mlir

6 lines

mlir-tblgen/

op-decl.td

2 lines

tools/

mlir-tblgen/

OpDefinitionsGen.cpp

71 lines

Diff 248587

View Options

mlir/include/mlir/IR/OpDefinition.h

View Options

mlir/lib/Dialect/SPIRV/SPIRVOps.cpp

View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

View Options

mlir/lib/IR/Operation.cpp

View Options

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

View Options

mlir/test/Dialect/SPIRV/control-flow-ops.mlir

View Options

mlir/test/mlir-tblgen/op-decl.td

View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir] Add traits for verifying the number of successors and providing relevant accessors.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 248587

mlir/include/mlir/IR/OpDefinition.h

mlir/lib/Dialect/SPIRV/SPIRVOps.cpp

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

mlir/lib/IR/Operation.cpp

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

mlir/test/Dialect/SPIRV/control-flow-ops.mlir

mlir/test/mlir-tblgen/op-decl.td

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

[mlir] Add traits for verifying the number of successors and providing relevant accessors.
ClosedPublic
Actions

Revision Contents
Changeset List