Page MenuHomePhabricator

[lld][ELF] Add some release notes
ClosedPublic

Authored by MaskRay on Feb 26 2020, 3:03 PM.

Details

Summary

Based on release/10.x

Diff Detail

Event Timeline

MaskRay created this revision.Feb 26 2020, 3:03 PM
MaskRay updated this revision to Diff 246844.Feb 26 2020, 3:10 PM
MaskRay retitled this revision from [lld][ELF] Add some release notes Based on release/10.x to [lld][ELF] Add some release notes.
MaskRay edited the summary of this revision. (Show Details)

Mention -Ttext=0

atanasyan added inline comments.
lld/docs/ReleaseNotes.rst
39

Why did you remove this line?

MaskRay updated this revision to Diff 246881.Feb 26 2020, 10:12 PM

Add more items

MaskRay marked an inline comment as done.Feb 26 2020, 10:25 PM
MaskRay added inline comments.
lld/docs/ReleaseNotes.rst
39

IIUC, you meant https://reviews.llvm.org/rL371554.

But this size optimization is generic. It also removes upto 3*maxpagesize for other targets.

For example, defaultMaxPageSize is also 65536 on AArch64/powerpc32/powerpc64.

MaskRay marked an inline comment as done.Feb 26 2020, 10:27 PM
MaskRay added inline comments.
lld/docs/ReleaseNotes.rst
107

Range extension thunks with addens are implemented for AArch64, PowerPC32 and PowerPC64.

@atanasyan It'd be nice to fix this for MIPS as well, or make it clear that MIPS does not need it.

MaskRay marked an inline comment as done.Feb 26 2020, 10:44 PM
MaskRay added inline comments.
lld/docs/ReleaseNotes.rst
95

@psmith Maybe you can find ARM contacts who are concerned about this matter.
I believe PT_GNU_PROPERTY in binutils/glibc is not going well. https://sourceware.org/ml/binutils/2020-02/msg00512.html

grimar added inline comments.Feb 27 2020, 12:17 AM
lld/docs/ReleaseNotes.rst
80–91

Seems you're missing empty lines between improvements.

atanasyan added inline comments.Feb 27 2020, 12:21 AM
lld/docs/ReleaseNotes.rst
39

I agree that this change is generic. Does it make a sense to mention about it in the release notes in a generic form?

107

MIPS does not use range extension thunks.

hans added inline comments.Feb 27 2020, 4:15 AM
lld/docs/ReleaseNotes.rst
99

I think this note is too small for something that's clearly a breaking change for some projects. Could it be lifted out into a "breaking changes" section, with the migration information clearly laid out?

102

Ditto.

Thanks for taking the lead on this. I've put a few suggestions for some cosmetic changes.

lld/docs/ReleaseNotes.rst
80–91

I suggest "with a" rather than "of a".
For certain "undefined symbol" errors, a definition with a close spelling will be suggested.

87

I suggest "3 times maxpagesize." as 3 maxpagesizes isn't the name of an option.

95

Thanks for pointing that out. The request to add PT_GNU_PROPERTY came from the Android team as the kernel required PT_GNU_PROPERTY. I'll mention it to them.

107

typo: "with addends"

113

Suggest no longer, as it more strongly implies a change.
The ARM port will no longer insert interworking thunks for non STT_FUNC symbols.

115

Insert

  • The ARM port will no longer interwork via changing a BL to a BLX for non STT_FUNC symbols. A warning will be given if this results in a change from previous LLD releases.

(D73542 <https://reviews.llvm.org/D73542_)

MaskRay updated this revision to Diff 246952.Feb 27 2020, 8:05 AM
MaskRay marked 7 inline comments as done.

Address comments

lld/docs/ReleaseNotes.rst
39

It is covered by the -z noseparate-code item below.

115

D73542 is not in the release/10.x branch.

@psmith I think it makes sense to cherry pick https://reviews.llvm.org/rG29c13615576b80129c8167df1d77f1ce98a97ae7 to release/10.x . Is that your intention?

psmith added inline comments.Feb 27 2020, 8:34 AM
lld/docs/ReleaseNotes.rst
115

Sorry, my mistake. Yes you are correct, I'm not intending for that to be cherry-picked.

hans added inline comments.Feb 27 2020, 8:53 AM
lld/docs/ReleaseNotes.rst
84

Can you please put the migration information here in the notes instead?

MaskRay marked an inline comment as done.Feb 27 2020, 8:59 AM
MaskRay added inline comments.
lld/docs/ReleaseNotes.rst
84

Where should I write the notes?

hans added inline comments.Feb 27 2020, 9:02 AM
lld/docs/ReleaseNotes.rst
84

Right here :-)

``-Ttext=0`` is no longer supported. (See PRxxx)
This is how to deal with it: ...
MaskRay updated this revision to Diff 247016.Feb 27 2020, 9:54 AM

Reword -Ttext=0

MaskRay marked 4 inline comments as done.Feb 27 2020, 9:54 AM
hans accepted this revision.Feb 27 2020, 9:58 AM

Thanks!

This revision is now accepted and ready to land.Feb 27 2020, 9:58 AM