Based on release/10.x
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
lld/docs/ReleaseNotes.rst | ||
---|---|---|
39 | Why did you remove this line? |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
39 | IIUC, you meant https://reviews.llvm.org/rL371554. But this size optimization is generic. It also removes upto 3*maxpagesize for other targets. For example, defaultMaxPageSize is also 65536 on AArch64/powerpc32/powerpc64. |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
107 |
@atanasyan It'd be nice to fix this for MIPS as well, or make it clear that MIPS does not need it. |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
95 | @psmith Maybe you can find ARM contacts who are concerned about this matter. |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
80–91 | Seems you're missing empty lines between improvements. |
Thanks for taking the lead on this. I've put a few suggestions for some cosmetic changes.
lld/docs/ReleaseNotes.rst | ||
---|---|---|
80–91 | I suggest "with a" rather than "of a". | |
87 | I suggest "3 times maxpagesize." as 3 maxpagesizes isn't the name of an option. | |
95 | Thanks for pointing that out. The request to add PT_GNU_PROPERTY came from the Android team as the kernel required PT_GNU_PROPERTY. I'll mention it to them. | |
107 | typo: "with addends" | |
113 | Suggest no longer, as it more strongly implies a change. | |
115 | Insert
(D73542 <https://reviews.llvm.org/D73542_) |
Address comments
lld/docs/ReleaseNotes.rst | ||
---|---|---|
39 | It is covered by the -z noseparate-code item below. | |
115 | D73542 is not in the release/10.x branch. @psmith I think it makes sense to cherry pick https://reviews.llvm.org/rG29c13615576b80129c8167df1d77f1ce98a97ae7 to release/10.x . Is that your intention? |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
115 | Sorry, my mistake. Yes you are correct, I'm not intending for that to be cherry-picked. |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
84 | Can you please put the migration information here in the notes instead? |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
84 | Where should I write the notes? |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
84 | Right here :-) ``-Ttext=0`` is no longer supported. (See PRxxx) This is how to deal with it: ... |
Why did you remove this line?