Page MenuHomePhabricator

[LTO] Rename legacy LTO files. NFC.
AbandonedPublic

Authored by sbc100 on Feb 21 2020, 3:35 PM.

Details

Summary

For clarity, and to match the header layout. I certainly found it
easier when poking around to have this split explicit.

Diff Detail

Event Timeline

sbc100 created this revision.Feb 21 2020, 3:35 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: uenoku. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
uenoku resigned from this revision.Feb 21 2020, 6:19 PM
jdoerfert resigned from this revision.Feb 21 2020, 9:51 PM
sstefan1 resigned from this revision.Feb 22 2020, 3:35 AM

I don't feel like this is necessary and creating a subdirectory without creating a new library feels weird. I agree the layout is a bit weird for new comer to LTO library but it is a relatively small hurdle. I don't exactly feel like I want to pay the cost of making git blame a bit harder.

Any other reason for changing the layout?

I don't feel like this is necessary and creating a subdirectory without creating a new library feels weird. I agree the layout is a bit weird for new comer to LTO library but it is a relatively small hurdle. I don't exactly feel like I want to pay the cost of making git blame a bit harder.

Any other reason for changing the layout?

Just what I said in the comment. I'm not wedded to this change. Will drop it if others don't think it makes sense.

Out of interest do you know if there are plans to remove the legacy code one day?

I don't feel like this is necessary and creating a subdirectory without creating a new library feels weird. I agree the layout is a bit weird for new comer to LTO library but it is a relatively small hurdle. I don't exactly feel like I want to pay the cost of making git blame a bit harder.

Any other reason for changing the layout?

Just what I said in the comment. I'm not wedded to this change. Will drop it if others don't think it makes sense.

Out of interest do you know if there are plans to remove the legacy code one day?

Apple is pretty much the only major user for legacy interfaces and Sony still uses it here and there. I don't think the code can be removed in the near future even all the major users move away from it because all the users of the legacy toolchains.

sbc100 abandoned this revision.Mar 3 2020, 2:42 PM