Page MenuHomePhabricator

[lldb/Plugins] Have one initializer per ABI plugin
ClosedPublic

Authored by JDevlieghere on Feb 11 2020, 5:02 PM.

Details

Summary

After the recent change that grouped some of the ABI plugins together, those plugins ended up with multiple initializers per plugin. This is incompatible with my proposed approach of generating the initializers dynamically, which is why I've grouped them together in a new entry point.

Diff Detail

Event Timeline

JDevlieghere created this revision.Feb 11 2020, 5:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 5:02 PM

Yeah, I expected something like this would be needed. This is fine, but I'd call the files ABIX86.h instead of just X86.h, to match the names of the classes and everything...

Yeah, I expected something like this would be needed. This is fine, but I'd call the files ABIX86.h instead of just X86.h, to match the names of the classes and everything...

Yup, I've updated the diff

labath accepted this revision.Feb 13 2020, 12:52 AM
labath added inline comments.
lldb/source/API/SystemInitializerFull.cpp
26–27

Are you missing the equivalent changes in SystemInitializerTest ?

This revision is now accepted and ready to land.Feb 13 2020, 12:52 AM
This revision was automatically updated to reflect the committed changes.