Page MenuHomePhabricator

[lldb/Initializers] Move all macOS initializers into PlatformMacOSX
ClosedPublic

Authored by JDevlieghere on Jan 21 2020, 9:13 AM.

Details

Summary

PlatformMacOSX is the main entry point to the plugin with the same name. This is part of a greater refactoring to auto generate the initializers. (D73067)

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 21 2020, 9:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 9:13 AM
labath accepted this revision.Jan 21 2020, 9:21 AM

this seems fine to me.

lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
9–36

The placement of all of this is still pretty odd (the Host/Config.h seems weirdly sandwiched between macos files). Just delete the whitespace and let clang-format sort things?

70–76

terminate

This revision is now accepted and ready to land.Jan 21 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.

This change is causing a build break on Windows (which was hidden by the Hexagon build break you just fixed :().

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12857/steps/build/logs/stdio