Page MenuHomePhabricator

[mlir][SideEffects] Replace the old SideEffects dialect interface with the newly added op interfaces/traits.
ClosedPublic

Authored by rriddle on Feb 11 2020, 1:14 PM.

Details

Summary

The old interface was a temporary stopgap to allow for implementing simple LICM that took side effects of region operations into account. Now that MLIR has proper support for specifying memory effects, this interface can be deleted.

Depends On D74440

Diff Detail

Event Timeline

rriddle created this revision.Feb 11 2020, 1:14 PM
jpienaar accepted this revision.Sat, Mar 7, 8:16 AM

Looks good thanks

This revision is now accepted and ready to land.Sat, Mar 7, 8:16 AM
This revision was automatically updated to reflect the committed changes.