This is an archive of the discontinued LLVM Phabricator instance.

[X86] Don't disable code in combineHorizontalPredicateResult just because we have avx512
ClosedPublic

Authored by craig.topper on Feb 11 2020, 11:31 AM.

Details

Summary

We aren't doing a good job of optimizing AVX512 outside of this code. So remove the bail out for AVX512 and replace with a FIXME. This at least gets us the AVX2 codegen.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 11 2020, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 11:31 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
spatel accepted this revision.Feb 11 2020, 12:38 PM

LGTM

llvm/test/CodeGen/X86/vector-compare-all_of.ll
31–35

This and the similar v2i64 case may warrant revisiting. We assumed movmsk was generally cheaper even on a 2-way reduction, but it depends how recent uarch have implemented it.

This revision is now accepted and ready to land.Feb 11 2020, 12:38 PM
This revision was automatically updated to reflect the committed changes.