Page MenuHomePhabricator

[VE] (fp)trunc+store & load+(fp)ext isel
ClosedPublic

Authored by simoll on Jan 31 2020, 3:49 AM.

Details

Summary

load+sext/zext/fpext and (fp)trunc+store isel legalization and tests

Diff Detail

Event Timeline

simoll created this revision.Jan 31 2020, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2020, 3:49 AM
simoll edited the summary of this revision. (Show Details)Jan 31 2020, 3:49 AM

Unit tests: pass. 62358 tests passed, 0 failed and 842 were skipped.

clang-tidy: fail. clang-tidy found 1 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm added inline comments.Jan 31 2020, 8:09 AM
llvm/test/CodeGen/VE/fp_extload_truncstore.ll
24

Might as well check the combination with half too

simoll marked an inline comment as done.Feb 3 2020, 1:41 AM
simoll added inline comments.
llvm/test/CodeGen/VE/fp_extload_truncstore.ll
24

Half conversion will require external function calls first since half conversion will be expanded for the VE.

arsenm accepted this revision.Feb 3 2020, 7:19 AM
This revision is now accepted and ready to land.Feb 3 2020, 7:19 AM
This revision was automatically updated to reflect the committed changes.