Page MenuHomePhabricator

[mlir] Expand shape functions in ShapeInference doc
ClosedPublic

Authored by jpienaar on Jan 28 2020, 12:09 PM.

Details

Summary

Start filling in some requirements for the shape function descriptions
that will be used to derive shape computations. This requiement part may
later be reworked to be part of the "context" section of shape dialect. Without
examples this may be a bit too abstract but I hope not (given mappings to
existing shape functions).

Diff Detail

Event Timeline

jpienaar created this revision.Jan 28 2020, 12:09 PM

Unit tests: fail. 62270 tests passed, 1 failed and 827 were skipped.

failed: Clang.CodeGenOpenCL/amdgpu-features.cl

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

stellaraccident accepted this revision.Feb 1 2020, 9:58 AM
stellaraccident added a subscriber: stellaraccident.

Some typos but lgtm. Thanks!

mlir/docs/ShapeInference.md
59

Typo. s/computer/compute/?

128

Typo: should be "map to or from"

216

Typo: should be "the shape function" and "do not intend"

229

... generating instructions...

247

Add comma: "Where not, ..."

253

... The extracted shape...

This revision is now accepted and ready to land.Feb 1 2020, 9:58 AM
jpienaar updated this revision to Diff 241905.Feb 1 2020, 2:42 PM
jpienaar marked 4 inline comments as done.

Fixing typos identified in review

jpienaar marked 2 inline comments as done.Feb 1 2020, 2:43 PM

Updated thanks

This revision was automatically updated to reflect the committed changes.
rriddle added inline comments.Feb 1 2020, 3:08 PM
mlir/docs/ShapeInference.md
57

This will likely need to be reworded in the near future.

63

What is the "shaped contained type"? Link?

64

nit: being the element type

72

Link to each of these types.

77

Can we remove IMHO and reword this to avoid starting with a 'But'?

82

shaped -> guided (or is the pun intended?)

91

Is the last * intended?

115

nit: descriptions

137

Wrap in ()?

145

& -> and

147

TensorList isn't a well known thing, e.g. I don't know what this point represents.

165

nit: It's a bit weird to start with an And.

195

representation

205

advanced

212

link to such literature?

Unit tests: fail. 62270 tests passed, 1 failed and 827 were skipped.

failed: Clang.CodeGenOpenCL/amdgpu-features.cl

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.