This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Fix passing lists to runtimes configures
ClosedPublic

Authored by smeenai on Jan 27 2020, 5:09 PM.

Details

Summary

We have to replace the ";" with "|" (since LLVMExternalProjectUtils uses
"|" as the LIST_SEPARATOR when invoking ExternalProject_Add) in
order for lists to be passed correctly to the runtimes CMake configures.
Remove the special case for LLVM_ENABLE_RUNTIMES, since it'll just get
handled by the general logic now.

Diff Detail

Event Timeline

smeenai created this revision.Jan 27 2020, 5:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2020, 5:09 PM
compnerd accepted this revision.Jan 28 2020, 9:16 AM
This revision is now accepted and ready to land.Jan 28 2020, 9:16 AM
This revision was automatically updated to reflect the committed changes.