This is an archive of the discontinued LLVM Phabricator instance.

Differential D73252

[runtimes] Support install-*-stripped targets
ClosedPublic

Authored by smeenai on Jan 22 2020, 10:37 PM.

Details

Reviewers
beanz
compnerd
phosek
plotfi
Commits
rGa308b98ecbb0: [runtimes] Support install-*-stripped targets
Summary

This is needed to support including runtime targets in
LLVM_DISTRIBUTION_COMPONENTS.

Diff Detail

Event Timeline

smeenai created this revision.Jan 22 2020, 10:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 10:37 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B44668: Diff 239780.Jan 22 2020, 10:43 PM
phosek accepted this revision.Jan 24 2020, 7:10 PM

LGTM

This revision is now accepted and ready to land.Jan 24 2020, 7:10 PM
Closed by commit rGa308b98ecbb0: [runtimes] Support install-*-stripped targets (authored by smeenai). · Explain WhyJan 27 2020, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
runtimes/
4 lines

Diff 240734

llvm/runtimes/CMakeLists.txt

Show First 20 Lines • Show All 425 Lines • ▼ Show 20 Lines function(runtime_register_target name target)
foreach(target_name IN LISTS SUB_COMPONENTS SUB_INSTALL_TARGETS) foreach(target_name IN LISTS SUB_COMPONENTS SUB_INSTALL_TARGETS)
set(${target_name}-${name} ${target_name}) set(${target_name}-${name} ${target_name})
list(APPEND ${name}_extra_targets ${target_name}-${name}) list(APPEND ${name}_extra_targets ${target_name}-${name})
endforeach() endforeach()
foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS}) foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
set(${component}-${name} ${component}) set(${component}-${name} ${component})
set(install-${component}-${name} install-${component}) set(install-${component}-${name} install-${component})
list(APPEND ${name}_extra_targets ${component}-${name} install-${component}-${name}) set(install-${component}-${name}-stripped install-${component}-stripped)
list(APPEND ${name}_extra_targets ${component}-${name} install-${component}-${name} install-${component}-${name}-stripped)
endforeach() endforeach()
if(LLVM_INCLUDE_TESTS) if(LLVM_INCLUDE_TESTS)
set(runtimes-test-depends-${name} runtimes-test-depends) set(runtimes-test-depends-${name} runtimes-test-depends)
set(check-runtimes-${name} check-runtimes) set(check-runtimes-${name} check-runtimes)
list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name}) list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name})
foreach(target_name IN LISTS SUB_CHECK_TARGETS) foreach(target_name IN LISTS SUB_CHECK_TARGETS)
set(${target_name}-${name} ${target_name}) set(${target_name}-${name} ${target_name})
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines else()
add_custom_target(check-runtimes) add_custom_target(check-runtimes)
add_custom_target(runtimes-test-depends) add_custom_target(runtimes-test-depends)
set(test_targets "") set(test_targets "")
endif() endif()
if(LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) if(LLVM_RUNTIME_DISTRIBUTION_COMPONENTS)
foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS}) foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
add_custom_target(${component}) add_custom_target(${component})
add_custom_target(install-${component}) add_custom_target(install-${component})
add_custom_target(install-${component}-stripped)
endforeach() endforeach()
endif() endif()
endif() endif()
foreach(name ${LLVM_RUNTIME_TARGETS}) foreach(name ${LLVM_RUNTIME_TARGETS})
runtime_register_target(${name} ${name} runtime_register_target(${name} ${name}
DEPENDS ${deps}) DEPENDS ${deps})
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines