Page MenuHomePhabricator

[Concepts] Remove -fconcepts-ts, enable concepts support under -std=c++2a
Needs ReviewPublic

Authored by saar.raz on Jan 21 2020, 5:17 PM.

Details

Summary

Enable concepts support under normal -std=c++2a and not under -fconcepts-ts, which is now deprecated.

Event Timeline

saar.raz created this revision.Jan 21 2020, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 5:17 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
saar.raz updated this revision to Diff 239472.Jan 21 2020, 5:58 PM

Readd -fconcepts-ts for deprecation diagnostic

rsmith added inline comments.Jan 23 2020, 11:56 AM
clang/include/clang/Basic/LangOptions.def
124

Looks like you picked up an unrelated change here; please revert this.

clang/lib/Frontend/InitPreprocessor.cpp
389

I think everything is done other than P0848, so according to https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#__cpp_concepts the appropriate value to use here is 201907L.

clang/www/cxx_status.html
884

As discussed off-line: I think P0848R3 is not yet done, so that row should be left as "No" instead of being marked as "Clang 10". (I'm assuming you'll land https://reviews.llvm.org/D73155 first, so P1616R1 will be done before this goes in.)