Page MenuHomePhabricator

[mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen
ClosedPublic

Authored by kariddi on Jan 21 2020, 1:26 PM.

Details

Summary

llvm::to_vector() accepts a Range value and not the pair of arguments
we are currently passing. Also we probably want the lowered LLVM
values in the vector, while operand_begin()/operand_end() on MLIR ops
returns MLIR types. lookupValues() seems the correct way to collect
such values.

Diff Detail

Event Timeline

kariddi created this revision.Jan 21 2020, 1:26 PM

Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped.

failed: Clang.Driver/cc-print-options.c

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

antiagainst accepted this revision.Jan 22 2020, 4:57 AM
This revision is now accepted and ready to land.Jan 22 2020, 4:57 AM
andydavis1 accepted this revision.Jan 22 2020, 6:47 AM
This revision was automatically updated to reflect the committed changes.