Page MenuHomePhabricator

andydavis1 (Andy Davis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 4:33 PM (11 w, 6 d)

Recent Activity

Today

andydavis1 committed rG31a346cc35c8: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and… (authored by andydavis1).
[MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and…
Tue, Mar 31, 8:53 AM
andydavis1 closed D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..
Tue, Mar 31, 8:53 AM · Restricted Project
andydavis1 updated the diff for D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..

rebasing

Tue, Mar 31, 8:49 AM · Restricted Project

Yesterday

andydavis1 added a comment to D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..

PTAL. Let me know if there are any more comments...Thanks!

Mon, Mar 30, 4:24 PM · Restricted Project
andydavis1 accepted D77004: [MLIR] Fix permuteLoops utility.

Thanks for fixing this bug Uday!

Mon, Mar 30, 8:03 AM · Restricted Project

Fri, Mar 27

andydavis1 accepted D76700: [MLIR] Introduce full/partial tile separation using if/else.
Fri, Mar 27, 3:27 PM · Restricted Project
andydavis1 updated the diff for D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..

addressing feedback

Fri, Mar 27, 12:01 PM · Restricted Project
andydavis1 added a comment to D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..

Thanks. I've addressed comments and will update with a new patch soon...

Fri, Mar 27, 9:05 AM · Restricted Project

Thu, Mar 26

andydavis1 created D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp..
Thu, Mar 26, 3:14 PM · Restricted Project

Wed, Mar 25

andydavis1 added inline comments to D76700: [MLIR] Introduce full/partial tile separation using if/else.
Wed, Mar 25, 5:21 PM · Restricted Project
andydavis1 accepted D76701: [MLIR] Add flat affine constraints method to round trip integer set.
Wed, Mar 25, 3:11 PM · Restricted Project

Mon, Mar 23

andydavis1 accepted D76667: [MLIR][NFC] flat affine constraints - refactor to share, renames.
Mon, Mar 23, 10:17 PM · Restricted Project
andydavis1 accepted D76633: [MLIR] move loopUnrollJamBy*Factor to loop transforms utils.
Mon, Mar 23, 1:06 PM · Restricted Project

Fri, Mar 20

andydavis1 added a comment to D76460: [mlir] [VectorOps] Introduce vector.transpose.

Thanks Aart. Yes, if its not too much work, I'd love to see this op take a permutation of dimensions of an N-D vector.

Fri, Mar 20, 10:17 AM · Restricted Project

Thu, Mar 19

andydavis1 added a comment to D76460: [mlir] [VectorOps] Introduce vector.transpose.

Thanks Aart. How hard would this be to generalize this op to make it N-D transpose op, instead of limit to 2D cases? For example, I may want to transpose the inner two dimensions of a N-D vector

Thu, Mar 19, 5:00 PM · Restricted Project

Fri, Mar 13

andydavis1 accepted D76117: NFC: modernize / clean up some loop transform utils, affine analysis utils.

Nice clean up!

Fri, Mar 13, 7:29 AM · Restricted Project

Thu, Mar 12

andydavis1 accepted D75956: [mlir] [VectorOps] Progressively lower vector.outerproduct to LLVM.

Aart. This looks good to me, but please wait for Nicolas' feedback as well. I think the two of you have chatted more about the outer-product stuff...

Thu, Mar 12, 10:18 AM · Restricted Project

Mon, Mar 9

andydavis1 accepted D75792: [mlir] NFC: remove IntegerValueSet / MutableIntegerSet.
Mon, Mar 9, 10:46 AM · Restricted Project

Thu, Mar 5

andydavis1 accepted D75694: NFC: remove stray decl of toAffineExpr, rename for readability.
Thu, Mar 5, 10:57 AM · Restricted Project

Feb 24 2020

andydavis1 accepted D75058: [mlir] simplify affine maps and operands in affine.min/max.

Thanks Alex!

Feb 24 2020, 8:58 AM · Restricted Project

Feb 20 2020

andydavis1 accepted D74880: [mlir] [VectorOps] Multi-dim reductions for lowering vector.contract.

Looks good, thanks Aart! One question, is the unrolling here deterministic in that the same op will always produce the same sequence of reductions after unrolling? Context is numerical stability across test runs....

Feb 20 2020, 1:25 PM · Restricted Project

Feb 19 2020

andydavis1 accepted D74797: [mlir] [VectorOps] Framework for progressive lowering of vector.contract.

Thanks Aart!

Feb 19 2020, 11:09 AM · Restricted Project

Feb 18 2020

andydavis1 added inline comments to D74797: [mlir] [VectorOps] Framework for progressive lowering of vector.contract.
Feb 18 2020, 2:53 PM · Restricted Project
andydavis1 accepted D74658: [mlir][NFC] Fix 'gatherLoops' utility.
Feb 18 2020, 12:44 PM · Restricted Project

Feb 11 2020

andydavis1 committed rG40b2eb353043: [mlir][AffineOps] Adds affine loop fusion transformation function to… (authored by andydavis1).
[mlir][AffineOps] Adds affine loop fusion transformation function to…
Feb 11 2020, 2:04 PM
andydavis1 closed D74330: [mlir][AffineOps] Adds affine loop fusion transformation function to LoopFusionUtils..
Feb 11 2020, 2:04 PM · Restricted Project
andydavis1 updated the diff for D74330: [mlir][AffineOps] Adds affine loop fusion transformation function to LoopFusionUtils..

addressing review comments

Feb 11 2020, 1:36 PM · Restricted Project
andydavis1 added a comment to D74330: [mlir][AffineOps] Adds affine loop fusion transformation function to LoopFusionUtils..

addressing comments.

Feb 11 2020, 1:36 PM · Restricted Project
andydavis1 added a comment to D74330: [mlir][AffineOps] Adds affine loop fusion transformation function to LoopFusionUtils..

addressing comments.

Feb 11 2020, 1:27 PM · Restricted Project
andydavis1 committed rG813bfffec34b: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp. (authored by andydavis1).
[mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp.
Feb 11 2020, 1:19 PM
andydavis1 closed D74327: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp..
Feb 11 2020, 1:19 PM · Restricted Project
andydavis1 updated the diff for D74327: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp..

rebasing with head

Feb 11 2020, 1:00 PM · Restricted Project
andydavis1 added a comment to D74327: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp..

addressing comments

Feb 11 2020, 1:00 PM · Restricted Project

Feb 10 2020

andydavis1 created D74330: [mlir][AffineOps] Adds affine loop fusion transformation function to LoopFusionUtils..
Feb 10 2020, 8:43 AM · Restricted Project
andydavis1 created D74327: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp..
Feb 10 2020, 8:11 AM · Restricted Project

Feb 6 2020

andydavis1 added a comment to D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..

Thanks. A fix is on the way...

Feb 6 2020, 9:53 AM · Restricted Project

Feb 5 2020

andydavis1 committed rGf9efce1dd5ce: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with… (authored by andydavis1).
[mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with…
Feb 5 2020, 4:29 PM
andydavis1 accepted D74014: [mlir] [VectorOps] generalized vector.contract semantics.

Looks good from my perspective.

Feb 5 2020, 4:29 PM · Restricted Project
andydavis1 closed D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..
Feb 5 2020, 4:29 PM · Restricted Project
andydavis1 updated the diff for D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..

rebasing

Feb 5 2020, 4:10 PM · Restricted Project
andydavis1 committed rG64871f778d52: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils. (authored by andydavis1).
[mlir] Adds affine loop fusion transformation function to LoopFusionUtils.
Feb 5 2020, 4:01 PM
andydavis1 closed D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..
Feb 5 2020, 4:01 PM · Restricted Project
andydavis1 updated the diff for D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..

rebasing with head

Feb 5 2020, 3:52 PM · Restricted Project
andydavis1 committed rG3ce8095c295e: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect. (authored by andydavis1).
[mlir][VectorOps] Add ShapeCastOp to the vector ops dialect.
Feb 5 2020, 3:52 PM
andydavis1 closed D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..
Feb 5 2020, 3:51 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

rebasing with head.

Feb 5 2020, 3:39 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

fixing formating take 2

Feb 5 2020, 3:20 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

fixed format.

Feb 5 2020, 1:58 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

addressing comments

Feb 5 2020, 1:40 PM · Restricted Project
andydavis1 added a comment to D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

addressing comments

Feb 5 2020, 1:30 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

rebasing with head

Feb 5 2020, 12:44 PM · Restricted Project

Feb 4 2020

andydavis1 accepted D73923: [mlir] [VectorOps] refined description of vector.contract.

Thanks Aart

Feb 4 2020, 10:58 AM · Restricted Project

Jan 31 2020

andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

Sync with github master

Jan 31 2020, 3:21 PM · Restricted Project
andydavis1 retitled D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type. from Support vector transfer_read/write unrolling for memrefs with vector element type. to [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..
Jan 31 2020, 3:12 PM · Restricted Project
andydavis1 added a comment to D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..

updated tags

Jan 31 2020, 3:12 PM · Restricted Project
andydavis1 added a comment to D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

Addressed River's comment.

Jan 31 2020, 2:16 PM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

addressing comments

Jan 31 2020, 2:16 PM · Restricted Project

Jan 30 2020

andydavis1 updated the summary of D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..
Jan 30 2020, 12:43 PM · Restricted Project
andydavis1 updated the diff for D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..

addresing comments

Jan 30 2020, 9:49 AM · Restricted Project
andydavis1 added a comment to D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..

thanks. Sending update ...

Jan 30 2020, 9:48 AM · Restricted Project
andydavis1 added a comment to D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

addressing comments

Jan 30 2020, 9:29 AM · Restricted Project
andydavis1 added a comment to D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..

addressing comments

Jan 30 2020, 9:29 AM · Restricted Project
andydavis1 updated the diff for D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..

addressing comments

Jan 30 2020, 9:29 AM · Restricted Project
andydavis1 updated the diff for D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..

addressing comments

Jan 30 2020, 9:00 AM · Restricted Project

Jan 29 2020

andydavis1 accepted D73593: [mlir] [VectorOps] consolidate all vector utilities to one header/cc file.

Great cleanup. The call sites look great. Thanks for doing this!

Jan 29 2020, 2:17 PM · Restricted Project
andydavis1 created D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect..
Jan 29 2020, 8:53 AM · Restricted Project

Jan 22 2020

andydavis1 added a comment to D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..

added commit message

Jan 22 2020, 2:04 PM · Restricted Project
andydavis1 updated the summary of D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..
Jan 22 2020, 2:04 PM · Restricted Project
andydavis1 abandoned D72933: Adds CastSliceOp to the vector ops dialect..
Jan 22 2020, 1:09 PM · Restricted Project
andydavis1 added inline comments to D72808: [mlir] [VectorOps] Lowering of vector.extract/insert_slices to LLVM IR.
Jan 22 2020, 11:37 AM · Restricted Project
andydavis1 accepted D73213: [mlir] [VectorOps] Implement vector tuple get folding.
Jan 22 2020, 11:37 AM · Restricted Project
andydavis1 added a comment to D73213: [mlir] [VectorOps] Implement vector tuple get folding.

Looks good. Thanks Aart!

Jan 22 2020, 11:37 AM · Restricted Project
andydavis1 removed a reviewer for D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils.: nicolasvasilache.
Jan 22 2020, 6:52 AM · Restricted Project
andydavis1 accepted D73137: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen.
Jan 22 2020, 6:52 AM · Restricted Project
andydavis1 created D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils..
Jan 22 2020, 6:43 AM · Restricted Project

Jan 21 2020

andydavis1 requested review of D72933: Adds CastSliceOp to the vector ops dialect..
Jan 21 2020, 7:16 AM · Restricted Project
andydavis1 added inline comments to D72933: Adds CastSliceOp to the vector ops dialect..
Jan 21 2020, 7:16 AM · Restricted Project

Jan 17 2020

andydavis1 created D72965: [mlir][VectorOps] Support vector transfer_read/write unrolling for memrefs with vector element type..
Jan 17 2020, 3:58 PM · Restricted Project
andydavis1 accepted D72955: [mlir] [VectorOps] Rename Utils.h into VectorUtils.h.
Jan 17 2020, 1:26 PM · Restricted Project
andydavis1 added a comment to D72955: [mlir] [VectorOps] Rename Utils.h into VectorUtils.h.

Thanks Aart.

Jan 17 2020, 1:26 PM · Restricted Project
andydavis1 added a comment to D72933: Adds CastSliceOp to the vector ops dialect..

addressing comments

Jan 17 2020, 12:57 PM · Restricted Project
andydavis1 updated the diff for D72933: Adds CastSliceOp to the vector ops dialect..

Addressing comments.

Jan 17 2020, 12:57 PM · Restricted Project
andydavis1 added a comment to D72926: [mlir] Generator converting LLVM intrinsics defs to MLIR ODS.

Looks great. Thanks Alex!

Jan 17 2020, 9:27 AM · Restricted Project
andydavis1 created D72933: Adds CastSliceOp to the vector ops dialect..
Jan 17 2020, 9:15 AM · Restricted Project

Jan 16 2020

andydavis1 updated the diff for D72731: [VectorOps] Update vector transfer read op comments..

Address comments

Jan 16 2020, 4:41 PM · Restricted Project

Jan 14 2020

andydavis1 added a comment to D72731: [VectorOps] Update vector transfer read op comments..

Submitting change.

Jan 14 2020, 2:08 PM · Restricted Project
andydavis1 added a reviewer for D72731: [VectorOps] Update vector transfer read op comments.: aartbik.
Jan 14 2020, 1:09 PM · Restricted Project
andydavis1 created D72731: [VectorOps] Update vector transfer read op comments..
Jan 14 2020, 1:09 PM · Restricted Project

Jan 7 2020

andydavis1 accepted D72310: [mlir][VectorOps] Implement strided_slice conversion.
Jan 7 2020, 5:05 PM · Restricted Project
andydavis1 accepted D72317: [mlir][VectorOps] Implement insert_strided_slice conversion.
Jan 7 2020, 4:58 PM · Restricted Project