Page MenuHomePhabricator

kariddi (Marcello Maggioni)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 21 2014, 12:38 PM (319 w, 3 d)

Recent Activity

Tue, Mar 24

kariddi added inline comments to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.
Tue, Mar 24, 4:57 PM · Restricted Project
kariddi added a comment to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.

Thanks for the patch! Some speedup in this area was dearly needed!

Tue, Mar 24, 2:00 PM · Restricted Project
kariddi added inline comments to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.
Tue, Mar 24, 2:00 PM · Restricted Project
kariddi updated the diff for D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC.

Addressing Matt's suggestions

Tue, Mar 24, 1:03 AM · Restricted Project

Sun, Mar 22

kariddi added reviewers for D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC: qcolombet, MatzeB, arsenm, rtereshin.
Sun, Mar 22, 8:56 PM · Restricted Project
kariddi created D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC.
Sun, Mar 22, 8:56 PM · Restricted Project

Thu, Mar 12

kariddi committed rGba5500f27a26: [RAGreedy] Fix minor typo in comment. NFC (authored by kariddi).
[RAGreedy] Fix minor typo in comment. NFC
Thu, Mar 12, 8:41 AM

Mon, Mar 9

kariddi committed rGa8f76e99ba59: Fix indentation using clang-format for Spiller.h. NFC Spiller.h had indentation… (authored by kariddi).
Fix indentation using clang-format for Spiller.h. NFC Spiller.h had indentation…
Mon, Mar 9, 11:20 AM
kariddi committed rGe5205074df0e: Move Spiller.h from lib/ directory path to include/CodeGen. NFC (authored by kariddi).
Move Spiller.h from lib/ directory path to include/CodeGen. NFC
Mon, Mar 9, 11:20 AM
kariddi closed D75830: Move Spiller.h from lib/ directory path to include/CodeGen. NFC.
Mon, Mar 9, 11:19 AM · Restricted Project

Sun, Mar 8

kariddi abandoned D75829: Fix indentation using clang-format for Spiller.h. NFC.
Sun, Mar 8, 12:16 PM · Restricted Project
kariddi created D75830: Move Spiller.h from lib/ directory path to include/CodeGen. NFC.
Sun, Mar 8, 11:44 AM · Restricted Project
kariddi updated the diff for D75829: Fix indentation using clang-format for Spiller.h. NFC.

Moving the Spiller.h file from lib/CodeGen to include/llvm/CodeGen allowing it to be visible from external users.

Sun, Mar 8, 11:12 AM · Restricted Project
kariddi abandoned D75829: Fix indentation using clang-format for Spiller.h. NFC.
Sun, Mar 8, 11:12 AM · Restricted Project
kariddi created D75829: Fix indentation using clang-format for Spiller.h. NFC.
Sun, Mar 8, 11:12 AM · Restricted Project

Mar 2 2020

kariddi added a comment to D73068: Reapply Avoid creating an immutable map in the Automaton class..

ping2 :)

Mar 2 2020, 11:36 AM · Restricted Project

Feb 24 2020

kariddi added a comment to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.

LGTM

Feb 24 2020, 9:35 AM · Restricted Project
kariddi accepted D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.
Feb 24 2020, 9:35 AM · Restricted Project

Feb 21 2020

kariddi added inline comments to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.
Feb 21 2020, 4:30 PM · Restricted Project
kariddi added a comment to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.

Thanks, nice cleanup!

Feb 21 2020, 4:20 PM · Restricted Project

Feb 5 2020

kariddi added a comment to D73068: Reapply Avoid creating an immutable map in the Automaton class..

ping

Feb 5 2020, 1:22 PM · Restricted Project

Jan 23 2020

kariddi committed rGbe9f09c768f9: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen. (authored by kariddi).
[mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen.
Jan 23 2020, 11:24 AM
kariddi closed D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 11:24 AM · Restricted Project
kariddi updated the diff for D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..

Ok, in this patch I'm stripping away the "TargetPrefix" off the intrinsics.
I don't know if there are some users that might want to keep that (at which point we might add it as a command line option)
but this avoids the nvvm.intr.nvvm.barrier0 problem, making the output just nvvm.intr.barrier0

Jan 23 2020, 10:36 AM · Restricted Project
kariddi added inline comments to D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 9:52 AM · Restricted Project
kariddi added inline comments to D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 9:30 AM · Restricted Project
kariddi added inline comments to D73068: Reapply Avoid creating an immutable map in the Automaton class..
Jan 23 2020, 8:34 AM · Restricted Project

Jan 22 2020

kariddi updated the diff for D73068: Reapply Avoid creating an immutable map in the Automaton class..

Fixing typo that made everything useless :P

Jan 22 2020, 5:59 PM · Restricted Project
kariddi created D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 22 2020, 2:31 PM · Restricted Project
kariddi committed rG04a151710e8b: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen (authored by kariddi).
[mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen
Jan 22 2020, 8:02 AM
kariddi closed D73137: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen.
Jan 22 2020, 8:02 AM · Restricted Project

Jan 21 2020

kariddi created D73137: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen.
Jan 21 2020, 1:28 PM · Restricted Project
kariddi committed rGcbf08d0f5751: [mlir] Fix LLVM intrinsic convesion generator for overloadable types. (authored by kariddi).
[mlir] Fix LLVM intrinsic convesion generator for overloadable types.
Jan 21 2020, 11:55 AM
kariddi closed D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 21 2020, 11:55 AM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Addressing comments

Jan 21 2020, 11:37 AM · Restricted Project
kariddi added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Comments addressed

Jan 21 2020, 11:37 AM · Restricted Project

Jan 20 2020

kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Fixing additional comments.

Jan 20 2020, 7:09 PM · Restricted Project
kariddi added inline comments to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 20 2020, 7:09 PM · Restricted Project
kariddi created D73068: Reapply Avoid creating an immutable map in the Automaton class..
Jan 20 2020, 4:45 PM · Restricted Project

Jan 17 2020

kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Removing space

Jan 17 2020, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Thanks River for the review. Addressed your comments.

Jan 17 2020, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Testing the change by adapting existing test

Jan 17 2020, 7:46 PM · Restricted Project
kariddi created D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 17 2020, 7:35 PM · Restricted Project

Jan 16 2020

kariddi committed rG051d330314cb: Avoid creating an immutable map in the Automaton class. (authored by kariddi).
Avoid creating an immutable map in the Automaton class.
Jan 16 2020, 6:54 PM
kariddi closed D72682: Avoid creating an immutable map in the Automaton class..
Jan 16 2020, 6:53 PM · Restricted Project

Jan 13 2020

kariddi updated the diff for D72682: Avoid creating an immutable map in the Automaton class..

Updating a stale comment where the old map used to live

Jan 13 2020, 10:21 PM · Restricted Project
kariddi created D72682: Avoid creating an immutable map in the Automaton class..
Jan 13 2020, 10:21 PM · Restricted Project

Oct 29 2019

kariddi added a comment to D69498: IR: Invert convergent attribute handling.

It absolutely makes sense for Clang as a GPU-programming frontend to set attributes appropriately when targeting the GPU. I'm objecting to making "convergence" and related "code layout is semantics" properties a universal part of the IR semantics that literally every frontend has to know about in order to get reasonable behavior from LLVM. I know that doing so makes sense to GPU backend developers because you mostly work exclusively on GPU toolchains, but AFAIK there are half a dozen GPU frontends and they're all forks of Clang, whereas there are dozens of LLVM frontends out there that don't care about targeting the GPU and quite possibly never will. (And even if they do target GPUs, they often will not care about exposing thread groups; many programming environments are just interested in taking advantage of the GPU's parallel-computation power and have no interest in inter-thread interference.)

John.

Oct 29 2019, 10:45 AM · Restricted Project
kariddi added a comment to D68994: [RFC] Redefine `convergent` in terms of dynamic instances.

Thanks for the answers! It was about time somebody tackled this problem in LLVM :)

Oct 29 2019, 9:38 AM · Restricted Project

Oct 28 2019

kariddi added a comment to D68994: [RFC] Redefine `convergent` in terms of dynamic instances.

What is the expectiation of lowering of a loop like the one you mentioned above?

Oct 28 2019, 7:19 PM · Restricted Project
kariddi added a comment to D69498: IR: Invert convergent attribute handling.

One thing to probably note is that its not only a "target specific" issue, but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all languages (to name a few) that have a concept of "convergence" and its not related only to the fact that they mostly run on a GPU, but to their programming model as well with respect to accessing textures and SIMD-wide communication and decision making (ballot)

Oct 28 2019, 7:06 PM · Restricted Project
kariddi created D69515: [LiveIntervalUnion] Expose extraction of last index in map for external users.
Oct 28 2019, 8:51 AM · Restricted Project

Oct 16 2019

kariddi committed rG5926eb5fe64a: Clang-formatting of some files in LiveRangeCalc header (LiveRangeCalc.h) (authored by kariddi).
Clang-formatting of some files in LiveRangeCalc header (LiveRangeCalc.h)
Oct 16 2019, 8:18 PM
kariddi committed rG6fc9563dba63: Move LiveRangeCalc header to publicily available position. NFC (authored by kariddi).
Move LiveRangeCalc header to publicily available position. NFC
Oct 16 2019, 8:18 PM
kariddi closed D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.
Oct 16 2019, 8:18 PM · Restricted Project
kariddi added a comment to D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.

I was just about to do the same

Oct 16 2019, 8:18 PM · Restricted Project
kariddi added a reviewer for D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available: aditya_nandakumar.
Oct 16 2019, 6:37 PM · Restricted Project
kariddi created D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.
Oct 16 2019, 6:36 PM · Restricted Project

Oct 10 2019

kariddi committed rGa064edf55e1c: [GISel] Simplifying return from else in function. NFC (authored by kariddi).
[GISel] Simplifying return from else in function. NFC
Oct 10 2019, 2:53 PM
kariddi committed rG0112123eea5f: [GISel] Allow getConstantVRegVal() to return G_FCONSTANT values. (authored by kariddi).
[GISel] Allow getConstantVRegVal() to return G_FCONSTANT values.
Oct 10 2019, 2:53 PM
kariddi closed D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 10 2019, 2:53 PM · Restricted Project
kariddi added a reviewer for D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines: arsenm.
Oct 10 2019, 2:15 PM · Restricted Project
kariddi updated the diff for D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.

So, I changed the getConstantVRegValWithLookThrough function with an extra operand. Honestly I couldn't see any reason why the new parameter should have been set as "false" by default, so I set it to true, because it seems what the design of GlobalISel seems to suggest considering the difference of float/int being "not-there".

Oct 10 2019, 12:20 PM · Restricted Project

Oct 9 2019

kariddi updated the diff for D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.

Clang-formatted test and corrected "MRI" to "*MRI"

Oct 9 2019, 5:08 PM · Restricted Project
kariddi added inline comments to D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 9 2019, 5:08 PM · Restricted Project
kariddi added inline comments to D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 9 2019, 3:54 PM · Restricted Project
kariddi added inline comments to D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 9 2019, 3:54 PM · Restricted Project
kariddi created D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 9 2019, 3:23 PM · Restricted Project
kariddi committed rGff38448148d0: [GISel] Refactor and split PatternMatchTest. NFC (authored by kariddi).
[GISel] Refactor and split PatternMatchTest. NFC
Oct 9 2019, 3:14 PM

Apr 26 2019

kariddi committed rGc596584f6707: [GlobalISel] Fix inserting copies in the right position for reg definitions (authored by kariddi).
[GlobalISel] Fix inserting copies in the right position for reg definitions
Apr 26 2019, 12:21 AM
kariddi closed D61157: [GlobalISel] Fix constrainOperandRegClass to insert copies in the right position for reg definitions.

Closed by r359282 (forgot to add differential revision to commit message)

Apr 26 2019, 12:20 AM · Restricted Project

Apr 25 2019

kariddi updated the diff for D61157: [GlobalISel] Fix constrainOperandRegClass to insert copies in the right position for reg definitions.

Cleanup

Apr 25 2019, 4:04 PM · Restricted Project
kariddi created D61157: [GlobalISel] Fix constrainOperandRegClass to insert copies in the right position for reg definitions.
Apr 25 2019, 3:56 PM · Restricted Project

Apr 6 2019

kariddi committed rG30eb5758112a: [ConstantRange] Shl considers full-set shifting to last bit position. (authored by kariddi).
[ConstantRange] Shl considers full-set shifting to last bit position.
Apr 6 2019, 11:13 PM

Apr 5 2019

kariddi updated the diff for D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Update coverage

Apr 5 2019, 8:48 AM · Restricted Project

Apr 4 2019

kariddi updated the diff for D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Hi Nikita, thanks for the review. I updated the patch based on your comment.

Apr 4 2019, 7:21 PM · Restricted Project

Mar 29 2019

kariddi added a comment to D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Here the one with your isWrappedSet changes

Mar 29 2019, 10:10 AM · Restricted Project
kariddi added a comment to D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Sorry, you are right, I didn't notice the operands were flipped. I'm not familiar with Z3 syntax and I got confused :)

Mar 29 2019, 10:07 AM · Restricted Project
kariddi updated the diff for D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Thanks Nuno,

Mar 29 2019, 1:38 AM · Restricted Project

Mar 3 2019

kariddi added a comment to D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.

Ping?

Mar 3 2019, 6:24 AM · Restricted Project

Feb 8 2019

kariddi created D57983: [ConstantRange] Shl of ConstantRanges considers full-set shifting to last bit position.
Feb 8 2019, 3:32 PM · Restricted Project

Oct 2 2018

kariddi created D52818: [Tablegen/SubtargetEmitter] Add Id field to ProcResource.
Oct 2 2018, 8:34 PM

Sep 24 2018

kariddi created D52447: [Tablegen/RFC] Introduce Mask to limit generation of inferred register classes.
Sep 24 2018, 6:22 PM · Restricted Project

Aug 21 2018

kariddi added a comment to D51024: [LICM] Modernize AliasSetTracker handling. NFC.

Thanks Alina!

Aug 21 2018, 1:31 PM

Aug 20 2018

kariddi updated the diff for D51024: [LICM] Modernize AliasSetTracker handling. NFC.

Yeah sure, thanks for suggesting the right person Chandler!

Aug 20 2018, 11:07 PM
kariddi created D51024: [LICM] Modernize AliasSetTracker handling. NFC.
Aug 20 2018, 8:33 PM
kariddi added a comment to D50909: [PSV] Make the API for TargetCustom values not trigger UB.

Thanks Matt, committed r340200

Aug 20 2018, 12:25 PM

Aug 17 2018

kariddi created D50909: [PSV] Make the API for TargetCustom values not trigger UB.
Aug 17 2018, 10:16 AM

Jul 13 2018

kariddi added a comment to D49124: [Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp.

Thanks David. I'll address your comment in my commit

Jul 13 2018, 9:36 AM
kariddi added a reviewer for D49124: [Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp: greened.
Jul 13 2018, 9:28 AM

Jul 12 2018

kariddi added a comment to D49124: [Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp.

ping

Jul 12 2018, 9:53 AM

Jul 9 2018

kariddi created D49124: [Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp.
Jul 9 2018, 7:56 PM

Jan 10 2018

kariddi closed D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

Pushed as r322248

Jan 10 2018, 6:08 PM

Jan 4 2018

kariddi accepted D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

LGTM

Jan 4 2018, 7:13 PM

Dec 11 2017

kariddi requested changes to D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

Hi Andrew, your change modifies the semantics of the function, in the sense that it becomes specialized into just collecting the data to perform "ConvertTwoCaseSwitch()" and it will not be possible to use it for other potential optimization that require the same data.

Dec 11 2017, 9:29 AM

Oct 4 2017

kariddi closed D38465: Move deleteDeadLoop to LoopUtils. NFC.
Oct 4 2017, 1:45 PM
kariddi added a comment to D38465: Move deleteDeadLoop to LoopUtils. NFC.

Thanks Anna.
Addressed your nitpicks.

Oct 4 2017, 1:45 PM
kariddi updated the diff for D38465: Move deleteDeadLoop to LoopUtils. NFC.

Updated confusing comment after Anna's suggestion.

Oct 4 2017, 8:58 AM
kariddi added inline comments to D38465: Move deleteDeadLoop to LoopUtils. NFC.
Oct 4 2017, 8:55 AM

Oct 3 2017

kariddi updated the diff for D38465: Move deleteDeadLoop to LoopUtils. NFC.

Thanks Anna for the review.

Oct 3 2017, 1:38 PM