Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Why is it better to generate a G_LSHR than a G_ANYEXT? On AArch64 I'd expect G_ANYEXT to be better, since we don't necessarily have to produce a real instruction there.
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
1451–1452 | Some debug output explaining that this isn't supported in non-integral address spaces might be useful for people trying to get GISel going. | |
1483–1484 | Debug output might be useful here too? |
Comment Actions
Why is it better to generate a G_LSHR than a G_ANYEXT? On AArch64 I'd expect G_ANYEXT to be better, since we don't necessarily have to produce a real instruction there.
Wait nevermind this is fine, this is legalization.
LGTM with inline comments.
Comment Actions
bc101ffd77738a5ec40fc16689eafaf1fb6fa8d6, but I moved the utility function change here to break the dependency on D72610
Some debug output explaining that this isn't supported in non-integral address spaces might be useful for people trying to get GISel going.