This is an archive of the discontinued LLVM Phabricator instance.

Differential D73016

[lldb/CMake] Make it possible to disable plugins at configuration time
Needs ReviewPublic

Authored by JDevlieghere on Jan 19 2020, 11:20 PM.

Details

Reviewers
xiaobai
labath
Group Reviewers
Restricted Project
Summary

This patch introduces a new CMake macro add_lldb_plugin_subdirectory to be used by the plugins. It's similar to add_lldb_tool_subdirectory which makes it possible to disable certain tools at configuration time. With the new macro, the same is possible for plugins. The difference is that it includes the plugin's parent directory in the name as well, so that the variable is named LDB_PLUGIN_SYMBOLFILE_PDF_BUILD rather than LDB_PLUGIN_PDB_BUILD.

I've updated the macOS CMake cache to give an idea of what this looks like.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 19 2020, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2020, 11:20 PM
Herald added subscribers: teemperor, abidh, aheejin, mgorny. · View Herald Transcript
teemperor added a comment.Jan 19 2020, 11:43 PM

How does this deal with linking flags etc.? Your cmake cache disabled LLDB_PLUGIN_SYMBOLFILE_NATIVEPDB_BUILD (well, it would without the LDB typo) but that just gives me a build that fails to link with ld: error: unable to find library -llldbPluginSymbolFileNativePDB.

Do we want to deal with dependencies between plugins? E.g. Language/CPlusPlus depending on Language/ClangCommon, so will CPlusPlus disabled too if I disable ClangCommon?

lldb/cmake/caches/Apple-lldb-macOS.cmake
21

LDB -> LLDB (here and in your description).

labath added a comment.Jan 20 2020, 12:55 AM

In principle, I think this is a good idea. We do have many optional components (and even more components that should be optional but aren't), that one may not need/want when building lldb for a specific use case. Also, libLLVM is configurable in a similar way. However:

  • as Raphael pointed out, this is incomplete. I'm not too worried about managing dependencies -- I'd consider this an expert feature, and I am happy with leaving it up to the user to ensure he does not disable a plugin that is used elsewhere (he should get a link error if he does). But that still leaves the question of how to register the plugins at startup. We currently have a hand-curated list of plugins in the SystemInitializer classes, and that will need to change somehow. This is further complicated by the fact that some plugins are also needed for lldb-server, while others (most) are used in liblldb only. The simplest solution (for usage, but maybe not for implementation) would be to have the plugins auto-register themselves via a global constructor. Some parts of llvm already to that, and we could create a special class for this which would also carry the annotations necessary to surpress the global constructor warnings. The alternative is to throw in a bunch of ifdefs into the SystemInitializers, which isn't particularly nice (though maybe it could be generated in cmake or via some .def tricks).
  • there will also be a need to somehow disable the tests for the relevant plugins. For instance all the NativePDB tests will fail when disabling that plugin (even on darwin, as the tests are written in a way to not require a windows host). I don't think we need to annotate all tests with the exact list of plugins that the require (that can be up to whoever wants to ensure that some configuration keeps working), but we should create some mechanism to do that.
  • I also wouldn't advertise this too much. Using these settings can easily send someone into uncharted waters, with random unexpected build errors or test failures -- we have enough of those even without new settings. And unlike LLVM_TARGETS_TO_BUILD, I doubt disabling some plugins will have measurable impact on the build time...
JDevlieghere added a parent revision: D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin.Jan 20 2020, 4:03 PM
JDevlieghere added a comment.Jan 20 2020, 4:12 PM
  • I'm aware of the linker issue when you reconfigure. I've spent quite some time investigating this and this seems related to the way libraries to link are cached by CMake. I verified that we're no longer passing the disabled library to target_link_libraries and yet the linker error remains. It looks like this might be fix starting with CMake 3.12 (https://cmake.org/cmake/help/git-stage/policy/CMP0073.html).
  • I've uploaded a patch for the system initializers: https://reviews.llvm.org/D73067

Very strong +1 on your last two points. I think I'll experiment a bit and then see which plugins I care about and how they affect the tests. I'll add a comment to the macro saying that using this functionality is a 100% at your own risk.

labath added a comment.Jan 21 2020, 1:14 AM
In D73016#1830303, @JDevlieghere wrote:
  • I'm aware of the linker issue when you reconfigure. I've spent quite some time investigating this and this seems related to the way libraries to link are cached by CMake. I verified that we're no longer passing the disabled library to target_link_libraries and yet the linker error remains. It looks like this might be fix starting with CMake 3.12 (https://cmake.org/cmake/help/git-stage/policy/CMP0073.html).

Interesting. This looks like something that we could hac^H^H^Hwork around even with cmake<=3.12 by force-setting the appropriate variable to "". If we cared enough about this, that is...

JDevlieghere updated this revision to Diff 247552.Mar 1 2020, 10:08 PM
  • Rebased.
  • Tested the cache configuration on macOS.
labath added a comment.Mar 2 2020, 1:00 AM

This looks fine, but I think you'll first need to handle the lit changes to allow skipping tests. Otherwise all of the pdb and breakpad tests will break once you do this. I guess the reason that this hasn't happened yet is because you have a typo in your cache file.

lldb/source/API/SBCommandReturnObject.cpp
98–101 ↗(On Diff #247552)

?

JDevlieghere planned changes to this revision.Mar 2 2020, 10:17 AM
JDevlieghere marked an inline comment as done.
In D73016#1900403, @labath wrote:

This looks fine, but I think you'll first need to handle the lit changes to allow skipping tests. Otherwise all of the pdb and breakpad tests will break once you do this. I guess the reason that this hasn't happened yet is because you have a typo in your cache file.

Right, I fixed the cache and then applied an old diff again. Shouldn't have tried to squeeze this in on a Sunday night. With the right cache values lldb-server is failing to link, so I'll have to take a look at that too.

lldb/source/API/SBCommandReturnObject.cpp
98–101 ↗(On Diff #247552)

Ugh, this should've been stashed, I was digging into some reproducer failure.

xiaobai added a comment.Mar 2 2020, 10:34 AM

I like the idea! The one thing that kind of bothers me about this is you can inadvertently break your build without realizing by disabling a plugin that some enabled plugins depend on. Hopefully one day we'll be able to improve the diagnostics around this.

JDevlieghere updated this revision to Diff 247947.Mar 3 2020, 10:08 AM
labath added a comment.Mar 4 2020, 3:57 AM

Looking this over again, I do see two open questions.

The first is that there is a disconnect between the place which *declares* something to be a plugin (the PLUGIN argument to add_lldb_library), and the place which *disables* something as a plugin (the macro invocation in the parent CMakeLists.txt). This creates a lot of potential for confusion and inconsistencies -- and indeed this patch already introduces some of those.

The second is the boilerplate required to disable the relevant tests. Right now you've just added the couple of features that you needed to disable the plugins of your choosing, but if we did that for all plugins, the code to do that would become fairly repetitive.

I am wondering if there isn't a way to solve both of these problems. For example, if we moved the disabling logic to the add_lldb_library function, then we could guarantee that only "real" plugins are eligible for being disabled. Also, since we already maintain a list of all plugin libraries, we could use this list to generate the appropriate lit features.

This would mean that we would not be able to reuse the llvm logic for skipping a directory, but that is literally just 4 lines of code, so I don't think it would be much of an issue. That may even make sense, because that llvm machinery was meant for disabling tools or entire subprojects, and not as a fine-grained control mechanism like this. In fact, this feature is kind of more similar to one choosing which components go into libLLVM.so, which is handled by a separate mechanism (LLVM_DYLIB_COMPONENTS).

Finally (though I don't know if you would consider this a feature or not), this way we might be able to arrange things so that the relevant plugins still get built even though they don't make their way into liblldb. That way one could still ensure that the relevant plugins build properly, and their unit tests could still run.

lldb/source/Plugins/LanguageRuntime/CMakeLists.txt
1–3

This isn't right. The actual plugins are located one level down (CPlusPlus/ItaniumABI, ObjC/AppleObjCRuntime, RenderScript/RenderScriptRuntime)

lldb/source/Plugins/Process/CMakeLists.txt
1–19

Some of these (Utility, Linux, NetBSD) aren't "real" plugins.

Revision Contents

PathSize
lldb/
cmake/
caches/
14 lines
modules/
6 lines
packages/
Python/
lldbsuite/
test/
1 line
source/
Plugins/
ABI/
2 lines
Architecture/
6 lines
Disassembler/
2 lines
DynamicLoader/
14 lines
Instruction/
10 lines
InstrumentationRuntime/
8 lines
JITLoader/
2 lines
Language/
6 lines
LanguageRuntime/
6 lines
MemoryHistory/
2 lines
ObjectContainer/
4 lines
ObjectFile/
12 lines
OperatingSystem/
2 lines
Platform/
18 lines
Process/
26 lines
ScriptInterpreter/
6 lines
StructuredData/
2 lines
SymbolFile/
10 lines
SymbolVendor/
6 lines
SystemRuntime/
2 lines
TypeSystem/
2 lines
UnwindAssembly/
4 lines
test/
API/
4 lines
functionalities/
postmortem/
minidump-new/
1 line
minidump/
1 line
wow64_minidump/
1 line
6 lines
Shell/
Minidump/
1 line
3 lines
ObjectFile/
Breakpad/
3 lines
SymbolFile/
Breakpad/
2 lines
6 lines
2 lines
unittests/
ObjectFile/
4 lines
Process/
8 lines

Diff 247947

lldb/cmake/caches/Apple-lldb-macOS.cmake

Show All 11 Lines
# Install location for LLDB.framework on the enduser machine. # Install location for LLDB.framework on the enduser machine.
# DESTDIR will be an extra prefix. # DESTDIR will be an extra prefix.
set(LLDB_FRAMEWORK_INSTALL_DIR /Applications/Xcode.app/Contents/SharedFrameworks CACHE STRING "") set(LLDB_FRAMEWORK_INSTALL_DIR /Applications/Xcode.app/Contents/SharedFrameworks CACHE STRING "")
# Install location for externalized debug-info on the build machine. # Install location for externalized debug-info on the build machine.
# DESTDIR will be an extra prefix. # DESTDIR will be an extra prefix.
set(LLDB_DEBUGINFO_INSTALL_PREFIX /debuginfo CACHE STRING "") set(LLDB_DEBUGINFO_INSTALL_PREFIX /debuginfo CACHE STRING "")
# Disable platform plugins.
set(LLDB_PLUGIN_PLATFORM_ANDROID_BUILD OFF CACHE BOOL "")
teemperorUnsubmitted
Not Done
ReplyInline Actions

LDB -> LLDB (here and in your description).

teemperor: `LDB` -> `LLDB` (here and in your description).
set(LLDB_PLUGIN_PLATFORM_FREEBSD_BUILD OFF CACHE BOOL "")
set(LLDB_PLUGIN_PLATFORM_NETBSD_BUILD OFF CACHE BOOL "")
set(LLDB_PLUGIN_PLATFORM_OPENBSD_BUILD OFF CACHE BOOL "")
set(LLDB_PLUGIN_PLATFORM_WINDOWS_BUILD OFF CACHE BOOL "")
# Disable minidump.
set(LLDB_PLUGIN_PROCESS_MINIDUMP_BUILD OFF CACHE BOOL "")
# Disable breakpad.
set(LLDB_PLUGIN_SYMBOLFILE_BREAKPAD_BUILD OFF CACHE BOOL "")
set(LLDB_PLUGIN_OBJECTFILE_BREAKPAD_BUILD OFF CACHE BOOL "")
set(LLVM_DISTRIBUTION_COMPONENTS set(LLVM_DISTRIBUTION_COMPONENTS
lldb lldb
liblldb liblldb
lldb-argdumper lldb-argdumper
darwin-debug darwin-debug
debugserver debugserver
CACHE STRING "") CACHE STRING "")

lldb/cmake/modules/AddLLDB.cmake

Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Linesfunction(add_lldb_executable name)
endif() endif()
endfunction() endfunction()
macro(add_lldb_tool_subdirectory name) macro(add_lldb_tool_subdirectory name)
add_llvm_subdirectory(LLDB TOOL ${name}) add_llvm_subdirectory(LLDB TOOL ${name})
endmacro() endmacro()
macro(add_lldb_plugin_subdirectory name)
get_filename_component(plugin ${CMAKE_CURRENT_SOURCE_DIR} NAME)
string(TOUPPER ${plugin} pluginUPPER)
add_llvm_subdirectory(LLDB "PLUGIN_${pluginUPPER}" ${name})
endmacro()
function(add_lldb_tool name) function(add_lldb_tool name)
cmake_parse_arguments(ARG "ADD_TO_FRAMEWORK" "" "" ${ARGN}) cmake_parse_arguments(ARG "ADD_TO_FRAMEWORK" "" "" ${ARGN})
if(LLDB_BUILD_FRAMEWORK AND ARG_ADD_TO_FRAMEWORK) if(LLDB_BUILD_FRAMEWORK AND ARG_ADD_TO_FRAMEWORK)
set(subdir LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Resources) set(subdir LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Resources)
add_lldb_executable(${name} add_lldb_executable(${name}
GENERATE_INSTALL GENERATE_INSTALL
INSTALL_PREFIX ${LLDB_FRAMEWORK_INSTALL_DIR}/${subdir} INSTALL_PREFIX ${LLDB_FRAMEWORK_INSTALL_DIR}/${subdir}
${ARG_UNPARSED_ARGUMENTS} ${ARG_UNPARSED_ARGUMENTS}
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines

lldb/packages/Python/lldbsuite/test/test_categories.py

Show All 31 Linesall_categories = {
'basic_process': 'Basic process execution sniff tests.', 'basic_process': 'Basic process execution sniff tests.',
'cmdline': 'Tests related to the LLDB command-line interface', 'cmdline': 'Tests related to the LLDB command-line interface',
'dyntype': 'Tests related to dynamic type support', 'dyntype': 'Tests related to dynamic type support',
'stresstest': 'Tests related to stressing lldb limits', 'stresstest': 'Tests related to stressing lldb limits',
'flakey': 'Flakey test cases, i.e. tests that do not reliably pass at each execution', 'flakey': 'Flakey test cases, i.e. tests that do not reliably pass at each execution',
'darwin-log': 'Darwin log tests', 'darwin-log': 'Darwin log tests',
'watchpoint': 'Watchpoint-related tests', 'watchpoint': 'Watchpoint-related tests',
'lldb-vscode': 'Visual Studio Code debug adaptor tests', 'lldb-vscode': 'Visual Studio Code debug adaptor tests',
'minidump': 'Minidump tests',
} }
def unique_string_match(yourentry, list): def unique_string_match(yourentry, list):
candidate = None candidate = None
for item in list: for item in list:
if not item.startswith(yourentry): if not item.startswith(yourentry):
continue continue
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

lldb/source/Plugins/ABI/CMakeLists.txt

foreach(target AArch64 ARM ARC Hexagon Mips PowerPC SystemZ X86) foreach(target AArch64 ARM ARC Hexagon Mips PowerPC SystemZ X86)
if (${target} IN_LIST LLVM_TARGETS_TO_BUILD) if (${target} IN_LIST LLVM_TARGETS_TO_BUILD)
add_subdirectory(${target}) add_lldb_plugin_subdirectory(${target})
endif() endif()
endforeach() endforeach()

lldb/source/Plugins/Architecture/CMakeLists.txt

add_subdirectory(Arm) add_lldb_plugin_subdirectory(Arm)
add_subdirectory(Mips) add_lldb_plugin_subdirectory(Mips)
add_subdirectory(PPC64) add_lldb_plugin_subdirectory(PPC64)

lldb/source/Plugins/Disassembler/CMakeLists.txt

add_subdirectory(LLVMC) add_lldb_plugin_subdirectory(LLVMC)

lldb/source/Plugins/DynamicLoader/CMakeLists.txt

add_subdirectory(Darwin-Kernel) add_lldb_plugin_subdirectory(Darwin-Kernel)
add_subdirectory(MacOSX-DYLD) add_lldb_plugin_subdirectory(MacOSX-DYLD)
add_subdirectory(POSIX-DYLD) add_lldb_plugin_subdirectory(POSIX-DYLD)
add_subdirectory(Static) add_lldb_plugin_subdirectory(Static)
add_subdirectory(Hexagon-DYLD) add_lldb_plugin_subdirectory(Hexagon-DYLD)
add_subdirectory(Windows-DYLD) add_lldb_plugin_subdirectory(Windows-DYLD)
add_subdirectory(wasm-DYLD) add_lldb_plugin_subdirectory(wasm-DYLD)

lldb/source/Plugins/Instruction/CMakeLists.txt

add_subdirectory(ARM) add_lldb_plugin_subdirectory(ARM)
add_subdirectory(ARM64) add_lldb_plugin_subdirectory(ARM64)
add_subdirectory(MIPS) add_lldb_plugin_subdirectory(MIPS)
add_subdirectory(MIPS64) add_lldb_plugin_subdirectory(MIPS64)
add_subdirectory(PPC64) add_lldb_plugin_subdirectory(PPC64)

lldb/source/Plugins/InstrumentationRuntime/CMakeLists.txt

add_subdirectory(ASan) add_lldb_plugin_subdirectory(ASan)
add_subdirectory(MainThreadChecker) add_lldb_plugin_subdirectory(MainThreadChecker)
add_subdirectory(TSan) add_lldb_plugin_subdirectory(TSan)
add_subdirectory(UBSan) add_lldb_plugin_subdirectory(UBSan)

lldb/source/Plugins/JITLoader/CMakeLists.txt

add_subdirectory(GDB) add_lldb_plugin_subdirectory(GDB)

lldb/source/Plugins/Language/CMakeLists.txt

add_lldb_plugin_subdirectory(CPlusPlus)
add_lldb_plugin_subdirectory(ObjC)
add_lldb_plugin_subdirectory(ObjCPlusPlus)
add_subdirectory(ClangCommon) add_subdirectory(ClangCommon)
add_subdirectory(CPlusPlus)
add_subdirectory(ObjC)
add_subdirectory(ObjCPlusPlus)

lldb/source/Plugins/LanguageRuntime/CMakeLists.txt

add_subdirectory(CPlusPlus) add_lldb_plugin_subdirectory(CPlusPlus)
add_subdirectory(ObjC) add_lldb_plugin_subdirectory(ObjC)
add_subdirectory(RenderScript) add_lldb_plugin_subdirectory(RenderScript)
labathUnsubmitted
Not Done
ReplyInline Actions

This isn't right. The actual plugins are located one level down (CPlusPlus/ItaniumABI, ObjC/AppleObjCRuntime, RenderScript/RenderScriptRuntime)

labath: This isn't right. The actual plugins are located one level down (CPlusPlus/ItaniumABI…

lldb/source/Plugins/MemoryHistory/CMakeLists.txt

add_subdirectory(asan) add_lldb_plugin_subdirectory(asan)

lldb/source/Plugins/ObjectContainer/CMakeLists.txt

add_subdirectory(BSD-Archive) add_lldb_plugin_subdirectory(BSD-Archive)
add_subdirectory(Universal-Mach-O) add_lldb_plugin_subdirectory(Universal-Mach-O)

lldb/source/Plugins/ObjectFile/CMakeLists.txt

add_subdirectory(Breakpad) add_lldb_plugin_subdirectory(Breakpad)
add_subdirectory(ELF) add_lldb_plugin_subdirectory(ELF)
add_subdirectory(Mach-O) add_lldb_plugin_subdirectory(Mach-O)
add_subdirectory(PECOFF) add_lldb_plugin_subdirectory(PECOFF)
add_subdirectory(JIT) add_lldb_plugin_subdirectory(JIT)
add_subdirectory(wasm) add_lldb_plugin_subdirectory(wasm)
No newline at end of file No newline at end of file

lldb/source/Plugins/OperatingSystem/CMakeLists.txt

if (LLDB_ENABLE_PYTHON) if (LLDB_ENABLE_PYTHON)
add_subdirectory(Python) add_lldb_plugin_subdirectory(Python)
endif() endif()

lldb/source/Plugins/Platform/CMakeLists.txt

#if (CMAKE_SYSTEM_NAME MATCHES "Linux") #if (CMAKE_SYSTEM_NAME MATCHES "Linux")
add_subdirectory(Linux) add_lldb_plugin_subdirectory(Linux)
#elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD") #elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD) add_lldb_plugin_subdirectory(FreeBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD") #elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
add_subdirectory(NetBSD) add_lldb_plugin_subdirectory(NetBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "OpenBSD") #elseif (CMAKE_SYSTEM_NAME MATCHES "OpenBSD")
add_subdirectory(OpenBSD) add_lldb_plugin_subdirectory(OpenBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin") #elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX) add_lldb_plugin_subdirectory(MacOSX)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Windows") #elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
add_subdirectory(Windows) add_lldb_plugin_subdirectory(Windows)
#endif() #endif()
add_subdirectory(POSIX) add_lldb_plugin_subdirectory(POSIX)
add_subdirectory(gdb-server) add_lldb_plugin_subdirectory(gdb-server)
add_subdirectory(Android) add_lldb_plugin_subdirectory(Android)

lldb/source/Plugins/Process/CMakeLists.txt

if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android") if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android")
add_subdirectory(Linux) add_lldb_plugin_subdirectory(Linux)
add_subdirectory(POSIX) add_lldb_plugin_subdirectory(POSIX)
elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD") elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD) add_lldb_plugin_subdirectory(FreeBSD)
add_subdirectory(POSIX) add_lldb_plugin_subdirectory(POSIX)
elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD") elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
add_subdirectory(NetBSD) add_lldb_plugin_subdirectory(NetBSD)
add_subdirectory(POSIX) add_lldb_plugin_subdirectory(POSIX)
elseif (CMAKE_SYSTEM_NAME MATCHES "Windows") elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
add_subdirectory(Windows/Common) add_lldb_plugin_subdirectory(Windows/Common)
elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin") elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX-Kernel) add_lldb_plugin_subdirectory(MacOSX-Kernel)
endif() endif()
add_subdirectory(gdb-remote) add_lldb_plugin_subdirectory(gdb-remote)
add_subdirectory(Utility) add_lldb_plugin_subdirectory(Utility)
add_subdirectory(elf-core) add_lldb_plugin_subdirectory(elf-core)
add_subdirectory(mach-core) add_lldb_plugin_subdirectory(mach-core)
add_subdirectory(minidump) add_lldb_plugin_subdirectory(minidump)
labathUnsubmitted
Not Done
ReplyInline Actions

Some of these (Utility, Linux, NetBSD) aren't "real" plugins.

labath: Some of these (Utility, Linux, NetBSD) aren't "real" plugins.

lldb/source/Plugins/ScriptInterpreter/CMakeLists.txt

add_subdirectory(None) add_lldb_plugin_subdirectory(None)
if (LLDB_ENABLE_PYTHON) if (LLDB_ENABLE_PYTHON)
add_subdirectory(Python) add_lldb_plugin_subdirectory(Python)
endif() endif()
if (LLDB_ENABLE_LUA) if (LLDB_ENABLE_LUA)
add_subdirectory(Lua) add_lldb_plugin_subdirectory(Lua)
endif() endif()

lldb/source/Plugins/StructuredData/CMakeLists.txt

add_subdirectory(DarwinLog) add_lldb_plugin_subdirectory(DarwinLog)

lldb/source/Plugins/SymbolFile/CMakeLists.txt

add_subdirectory(Breakpad) add_lldb_plugin_subdirectory(Breakpad)
add_subdirectory(DWARF) add_lldb_plugin_subdirectory(DWARF)
add_subdirectory(Symtab) add_lldb_plugin_subdirectory(Symtab)
add_subdirectory(NativePDB) add_lldb_plugin_subdirectory(NativePDB)
add_subdirectory(PDB) add_lldb_plugin_subdirectory(PDB)

lldb/source/Plugins/SymbolVendor/CMakeLists.txt

if (CMAKE_SYSTEM_NAME MATCHES "Darwin") if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX) add_lldb_plugin_subdirectory(MacOSX)
endif() endif()
add_subdirectory(ELF) add_lldb_plugin_subdirectory(ELF)
add_subdirectory(wasm) add_lldb_plugin_subdirectory(wasm)

lldb/source/Plugins/SystemRuntime/CMakeLists.txt

add_subdirectory(MacOSX) add_lldb_plugin_subdirectory(MacOSX)

lldb/source/Plugins/TypeSystem/CMakeLists.txt

add_subdirectory(Clang) add_lldb_plugin_subdirectory(Clang)

lldb/source/Plugins/UnwindAssembly/CMakeLists.txt

add_subdirectory(InstEmulation) add_lldb_plugin_subdirectory(InstEmulation)
add_subdirectory(x86) add_lldb_plugin_subdirectory(x86)

lldb/test/API/CMakeLists.txt

Show All 37 Lines
set(LLDB_TEST_COMMON_ARGS set(LLDB_TEST_COMMON_ARGS
-s -s
${CMAKE_BINARY_DIR}/lldb-test-traces ${CMAKE_BINARY_DIR}/lldb-test-traces
-S nm -S nm
-u CXXFLAGS -u CXXFLAGS
-u CFLAGS -u CFLAGS
) )
if (NOT LLDB_PLUGIN_PROCESS_MINIDUMP_BUILD)
list(APPEND LLDB_TEST_COMMON_ARGS --skip-category minidump)
endif()
# Set the path to the default lldb test executable. # Set the path to the default lldb test executable.
set(LLDB_DEFAULT_TEST_EXECUTABLE "${LLVM_RUNTIME_OUTPUT_INTDIR}/lldb${CMAKE_EXECUTABLE_SUFFIX}") set(LLDB_DEFAULT_TEST_EXECUTABLE "${LLVM_RUNTIME_OUTPUT_INTDIR}/lldb${CMAKE_EXECUTABLE_SUFFIX}")
# Set the paths to default llvm tools. # Set the paths to default llvm tools.
set(LLDB_DEFAULT_TEST_DSYMUTIL "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/dsymutil${CMAKE_EXECUTABLE_SUFFIX}") set(LLDB_DEFAULT_TEST_DSYMUTIL "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/dsymutil${CMAKE_EXECUTABLE_SUFFIX}")
set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SUFFIX}") set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SUFFIX}")
if (TARGET clang) if (TARGET clang)
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines

lldb/test/API/functionalities/postmortem/minidump-new/.categories

  • This file was added.
minidump

lldb/test/API/functionalities/postmortem/minidump/.categories

  • This file was added.
minidump

lldb/test/API/functionalities/postmortem/wow64_minidump/.categories

  • This file was added.
minidump

lldb/test/CMakeLists.txt

Show First 20 Lines • Show All 147 Lines • ▼ Show 20 Lines
# These values are not canonicalized within LLVM. # These values are not canonicalized within LLVM.
llvm_canonicalize_cmake_booleans( llvm_canonicalize_cmake_booleans(
LLDB_ENABLE_PYTHON LLDB_ENABLE_PYTHON
LLDB_ENABLE_LUA LLDB_ENABLE_LUA
LLDB_ENABLE_LZMA LLDB_ENABLE_LZMA
LLVM_ENABLE_ZLIB LLVM_ENABLE_ZLIB
LLVM_ENABLE_SHARED_LIBS LLVM_ENABLE_SHARED_LIBS
LLDB_IS_64_BITS) LLDB_IS_64_BITS
LLDB_PLUGIN_OBJECTFILE_BREAKPAD_BUILD
LLDB_PLUGIN_SYMBOLFILE_BREAKPAD_BUILD
LLDB_PLUGIN_PROCESS_MINIDUMP_BUILD
)
# Configure the individual test suites. # Configure the individual test suites.
add_subdirectory(API) add_subdirectory(API)
add_subdirectory(Shell) add_subdirectory(Shell)
add_subdirectory(Unit) add_subdirectory(Unit)
# Configure the top level test suite. # Configure the top level test suite.
configure_lit_site_cfg( configure_lit_site_cfg(
Show All 18 Lines

lldb/test/Shell/Minidump/breakpad-symbols.test

# REQUIRES: breakpad
# Test that we can attach breakpad symbols to the "placeholder" modules created # Test that we can attach breakpad symbols to the "placeholder" modules created
# for minidump files. # for minidump files.
# #
# The minidump input for this test taken from packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new # The minidump input for this test taken from packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new
# RUN: yaml2obj %S/Inputs/linux-x86_64.yaml > %t # RUN: yaml2obj %S/Inputs/linux-x86_64.yaml > %t
# RUN: %lldb -c %t \ # RUN: %lldb -c %t \
# RUN: -o "target symbols add -s /tmp/test/linux-x86_64 %S/Inputs/linux-x86_64.syms" \ # RUN: -o "target symbols add -s /tmp/test/linux-x86_64 %S/Inputs/linux-x86_64.syms" \
Show All 19 Lines

lldb/test/Shell/Minidump/lit.local.cfg

config.suffixes = ['.test', '.yaml'] config.suffixes = ['.test', '.yaml']
if 'minidump' not in config.available_features:
config.unsupported = True

lldb/test/Shell/ObjectFile/Breakpad/lit.local.cfg

config.suffixes = ['.test'] config.suffixes = ['.test']
if 'breakpad' not in config.available_features:
config.unsupported = True

lldb/test/Shell/SymbolFile/Breakpad/lit.local.cfg

  • This file was added.
if 'breakpad' not in config.available_features:
config.unsupported = True

lldb/test/Shell/lit.cfg.py

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
# possible to capture a test suite run and then rerun all the test from the # possible to capture a test suite run and then rerun all the test from the
# just captured reproducer. # just captured reproducer.
lldb_repro_mode = lit_config.params.get('lldb-run-with-repro', None) lldb_repro_mode = lit_config.params.get('lldb-run-with-repro', None)
if lldb_repro_mode: if lldb_repro_mode:
config.available_features.add('lldb-repro') config.available_features.add('lldb-repro')
lit_config.note("Running Shell test with lldb-repo in {} mode.".format(lldb_repro_mode)) lit_config.note("Running Shell test with lldb-repo in {} mode.".format(lldb_repro_mode))
toolchain.use_lldb_repro_substitutions(config, lldb_repro_mode) toolchain.use_lldb_repro_substitutions(config, lldb_repro_mode)
if config.lldb_enable_breakpad:
config.available_features.add('breakpad')
if config.lldb_enable_minidump:
config.available_features.add('minidump')
llvm_config.use_default_substitutions() llvm_config.use_default_substitutions()
toolchain.use_lldb_substitutions(config) toolchain.use_lldb_substitutions(config)
toolchain.use_support_substitutions(config) toolchain.use_support_substitutions(config)
if re.match(r'^arm(hf.*-linux)|(.*-linux-gnuabihf)', config.target_triple): if re.match(r'^arm(hf.*-linux)|(.*-linux-gnuabihf)', config.target_triple):
config.available_features.add("armhf-linux") config.available_features.add("armhf-linux")
def calculate_arch_features(arch_string): def calculate_arch_features(arch_string):
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines

lldb/test/Shell/lit.site.cfg.py.in

Show All 14 Lines
config.target_triple = "@TARGET_TRIPLE@" config.target_triple = "@TARGET_TRIPLE@"
config.python_executable = "@PYTHON_EXECUTABLE@" config.python_executable = "@PYTHON_EXECUTABLE@"
config.have_zlib = @LLVM_ENABLE_ZLIB@ config.have_zlib = @LLVM_ENABLE_ZLIB@
config.lldb_enable_lzma = @LLDB_ENABLE_LZMA@ config.lldb_enable_lzma = @LLDB_ENABLE_LZMA@
config.host_triple = "@LLVM_HOST_TRIPLE@" config.host_triple = "@LLVM_HOST_TRIPLE@"
config.lldb_bitness = 64 if @LLDB_IS_64_BITS@ else 32 config.lldb_bitness = 64 if @LLDB_IS_64_BITS@ else 32
config.lldb_enable_python = @LLDB_ENABLE_PYTHON@ config.lldb_enable_python = @LLDB_ENABLE_PYTHON@
config.lldb_enable_lua = @LLDB_ENABLE_LUA@ config.lldb_enable_lua = @LLDB_ENABLE_LUA@
config.lldb_enable_breakpad = @LLDB_PLUGIN_OBJECTFILE_BREAKPAD_BUILD@ and @LLDB_PLUGIN_SYMBOLFILE_BREAKPAD_BUILD@
config.lldb_enable_minidump = @LLDB_PLUGIN_PROCESS_MINIDUMP_BUILD@
config.lldb_build_directory = "@LLDB_TEST_BUILD_DIRECTORY@" config.lldb_build_directory = "@LLDB_TEST_BUILD_DIRECTORY@"
# The shell tests use their own module caches. # The shell tests use their own module caches.
config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell") config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell")
config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell") config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell")
# Support substitution of the tools and libs dirs with user parameters. This is # Support substitution of the tools and libs dirs with user parameters. This is
# used when we can't determine the tool dir at configuration time. # used when we can't determine the tool dir at configuration time.
try: try:
Show All 15 Lines

lldb/unittests/ObjectFile/CMakeLists.txt

if (LLDB_PLUGIN_OBJECTFILE_BREAKPAD_BUILD)
add_subdirectory(Breakpad) add_subdirectory(Breakpad)
endif()
add_subdirectory(ELF) add_subdirectory(ELF)
add_subdirectory(PECOFF) add_subdirectory(PECOFF)

lldb/unittests/Process/CMakeLists.txt

add_subdirectory(gdb-remote)
if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android") if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android")
add_subdirectory(Linux) add_subdirectory(Linux)
add_subdirectory(POSIX) add_subdirectory(POSIX)
endif() endif()
if (LLDB_PLUGIN_PROCESS_GDB_REMOTE_BUILD)
add_subdirectory(gdb-remote)
endif()
if (LLDB_PLUGIN_PROCESS_MINIDUMP_BUILD)
add_subdirectory(minidump) add_subdirectory(minidump)
endif()