This is an archive of the discontinued LLVM Phabricator instance.

Remove AllTargetsAsmPrinters
ClosedPublic

Authored by thakis on Jan 17 2020, 4:07 PM.

Details

Summary

It's been an empty target since r360498 and friends
(git log --grep='Move InstPrinter files to MCTargetDesc.' llvm/lib/Target),
but due to hwo the way these targets are structured it was silently
an empty target without anyone noticing.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Jan 17 2020, 4:07 PM
Herald added a reviewer: andreadb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Jan 17 2020, 4:11 PM

Thanks for fixing CMake:)

The empty target seems to have caused the failure in http://45.33.8.238/linux/7815/step_4.txt

This revision is now accepted and ready to land.Jan 17 2020, 4:11 PM

Thanks for fixing CMake:)

The empty target seems to have caused the failure in http://45.33.8.238/linux/7815/step_4.txt

What has happened there (I think) is that @epastor copied the llvm-ml cmakelists.txt from an existing cmakelists.txt that had the AllTargetsAsmPrinters target, and the copied that to the gn build file – and the gn build is a bit more explicit about which things exist and which don't :) (I had fixed the gn build in 6afa0e88e32558)

thakis closed this revision.Jan 17 2020, 4:24 PM

Bleh, forgot to add "Differential Revision:" footer. Landed in 1d568bf9605c05ff088b244d7894ab2d88da9811