There are a few global (cl::opt) controls that enable optional
behavior in GVN. Introduce GVNOptions that provide corresponding
per-pass instance controls.
That will allow to use GVN multiple times in pipeline each time
with different settings.
Paths
| Differential D72732
[GVN] introduce GVNOptions to control GVN pass behavior ClosedPublic Authored by fedor.sergeev on Jan 14 2020, 1:12 PM.
Details Summary There are a few global (cl::opt) controls that enable optional That will allow to use GVN multiple times in pipeline each time
Diff Detail
Event TimelineComment Actions Don't you want to add a code to be able to set GVN options from command line for new pass manager? Or it is a follow-up change? fedor.sergeev added inline comments.
Comment Actions
That should go as a followup. Comment Actions
I'm fine with follow-up. fedor.sergeev added a child revision: D72752: [GVN] add GVN parameters parsing to new pass manager.Jan 14 2020, 11:59 PM
Comment Actions LGTM, thanks. Please wait a day or so with committing, in case there are additional comments. This revision is now accepted and ready to land.Jan 15 2020, 2:07 PM fedor.sergeev added inline comments. fedor.sergeev added inline comments.
Comment Actions reintroduced default parameter for Legacy pass constructor Closed by commit rG3478551bf3d2: [GVN] introduce GVNOptions to control GVN pass behavior (authored by fedor.sergeev). · Explain WhyJan 16 2020, 9:35 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 238529 llvm/include/llvm/Transforms/Scalar/GVN.h
llvm/lib/Transforms/Scalar/GVN.cpp
|
Update comment?