This is an archive of the discontinued LLVM Phabricator instance.

Differential D72668

[Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds
ClosedPublic

Authored by MaskRay on Jan 13 2020, 4:59 PM.

Details

Reviewers
leonardchan
nathanchance
bcain
kparzysz
sidneym
Commits
rG1ca51c06729d: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for…

Diff Detail

Event Timeline

MaskRay created this revision.Jan 13 2020, 4:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2020, 4:59 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
merge_guards_bot added a subscriber: merge_guards_bot.Jan 13 2020, 5:09 PM

Unit tests: pass. 61798 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster completed remote builds in B43881: Diff 237816.Jan 13 2020, 5:09 PM
nathanchance accepted this revision.Jan 13 2020, 5:12 PM

This fixes the error for me and looks better from a documentation perspective.

This revision is now accepted and ready to land.Jan 13 2020, 5:12 PM
MaskRay edited reviewers, added: sidneym; removed: sidney.Jan 14 2020, 10:39 AM
sidneym accepted this revision.Jan 14 2020, 1:08 PM
Closed by commit rG1ca51c06729d: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for… (authored by MaskRay). · Explain WhyJan 14 2020, 1:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
test/
Driver/
3 lines

Diff 238085

clang/test/Driver/hexagon-toolchain-elf.c

Show First 20 Lines • Show All 532 Lines • ▼ Show 20 Lines
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ // RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
// RUN: -mcpu=hexagonv60 \ // RUN: -mcpu=hexagonv60 \
// RUN: %s 2>&1 \ // RUN: %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK080 %s // RUN: | FileCheck -check-prefix=CHECK080 %s
// CHECK080: "-cc1" // CHECK080: "-cc1"
// CHECK080: "-Wreturn-type" // CHECK080: "-Wreturn-type"
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// Default, not passing -fuse-ld // Default, hexagon-link is used
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// RUN: %clang -### -target hexagon-unknown-elf \ // RUN: %clang -### -target hexagon-unknown-elf \
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ // RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
// RUN: -mcpu=hexagonv60 \ // RUN: -mcpu=hexagonv60 \
// RUN: -fuse-ld=fake-value-to-ignore-CLANG_DEFAULT_LINKER \
// RUN: %s 2>&1 \ // RUN: %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK081 %s // RUN: | FileCheck -check-prefix=CHECK081 %s
// REQUIRES: hexagon-registered-target // REQUIRES: hexagon-registered-target
// CHECK081: "-march=hexagon" // CHECK081: "-march=hexagon"
// CHECK081: "-mcpu=hexagonv60" // CHECK081: "-mcpu=hexagonv60"
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// Passing -fuse-ld=lld // Passing -fuse-ld=lld
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// RUN: %clang -### -target hexagon-unknown-elf \ // RUN: %clang -### -target hexagon-unknown-elf \
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ // RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
// RUN: -mcpu=hexagonv60 \ // RUN: -mcpu=hexagonv60 \
// RUN: -fuse-ld=lld \ // RUN: -fuse-ld=lld \
// RUN: %s 2>&1 \ // RUN: %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK082 %s // RUN: | FileCheck -check-prefix=CHECK082 %s
// CHECK082-NOT: -march= // CHECK082-NOT: -march=
// CHECK082-NOT: -mcpu= // CHECK082-NOT: -mcpu=