This was dropping the invariant metadata on dead argument loads, so
they weren't deleted.
Atomics still need to be fixed the same way. Also, apparently store
was never preserving dereferencable which should also be fixed.
Paths
| Differential D72599
GlobalISel: Preserve load/store metadata in IRTranslator ClosedPublic Authored by arsenm on Jan 13 2020, 5:13 AM.
Details Summary This was dropping the invariant metadata on dead argument loads, so Atomics still need to be fixed the same way. Also, apparently store
Diff Detail Event Timelinearsenm added a child revision: D72603: GlobalISel: Apply target MMO flags to atomics.Jan 13 2020, 5:27 AM This revision is now accepted and ready to land.Jan 16 2020, 9:18 AM
Revision Contents
Diff 237632 llvm/include/llvm/CodeGen/TargetLowering.h
llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
llvm/lib/CodeGen/TargetLoweringBase.cpp
llvm/lib/Target/AArch64/AArch64ISelLowering.h
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm/lib/Target/SystemZ/SystemZISelLowering.h
llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
llvm/lib/Target/XCore/XCoreISelLowering.h
llvm/lib/Target/XCore/XCoreISelLowering.cpp
llvm/test/CodeGen/AArch64/GlobalISel/constant-dbg-loc.ll
llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-load-metadata.ll
llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-stackprotect-check.ll
llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-store-metadata.ll
llvm/test/CodeGen/AArch64/GlobalISel/localizer-arm64-tti.ll
llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-function-args.ll
llvm/test/CodeGen/Mips/GlobalISel/irtranslator/var_arg.ll
llvm/test/CodeGen/X86/GlobalISel/x86_64-irtranslator-struct-return.ll
|