[clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene.Zelenko]

Summary

I added subsubsections for typical Clang-tidy entries in Release Notes, so now scripts are aware of this changes.

I don't have GitHub commit access, so please commit changes.

[alexfh]

LG with a nit, if this works.

clang-tools-extra/clang-tidy/add_new_check.py

223

"New check aliases" would be less ambiguous.

[Eugene.Zelenko]

Renamed "New aliases" to "New check aliases".

[Eugene.Zelenko]

Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch.

[alexfh]

In D72527#1817518, @Eugene.Zelenko wrote:

Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch.

Yep, sorting of the list on rename is a separate issue.
The patch LGTM.

[Eugene.Zelenko]

Just ping.

[alexfh]

In D72527#1843427, @Eugene.Zelenko wrote:

Just ping.

Are you waiting for other reviewers or for me to "Accept Revision"? If the latter, "stamped", but I've already said that the patch LGTM.

[Eugene.Zelenko]

As I wrote, I don't have GitHub commit access, so I need help with commit.

[njames93]

In D72527#1843475, @Eugene.Zelenko wrote:

As I wrote, I don't have GitHub commit access, so I need help with commit.

Needs rebasing on trunk, ReleaseNotes.rst is causing conflicts

[alexfh]

In D72527#1843475, @Eugene.Zelenko wrote:

As I wrote, I don't have GitHub commit access, so I need help with commit.

Sorry, missed that part of the patch description. As per Nathan's comment, please rebase the patch.

[Eugene.Zelenko]

Rebase from master.

[njames93]

In D72527#1845009, @Eugene.Zelenko wrote:

Rebase from master.

Committed, I still not 100% sure on landing on behalf of someone else so I think it hasn't credited you unfortunately, arc should have better docs...

clang-tools-extra/clang-tidy/add_new_check.py

 # Adds a release notes entry.
 def add_release_notes(module_path, module, check_name):
   check_name_dashes = module + '-' + check_name
   filename = os.path.normpath(os.path.join(module_path,
                                            '../../docs/ReleaseNotes.rst'))
   with open(filename, 'r') as f:
     lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
   with open(filename, 'w') as f:
     note_added = False
     header_found = False
     next_header_found = False
     add_note_here = False
for line in lines:
           next_header_found = True
           add_note_here = True
 
         if match:
           header_found = True
           f.write(line)
           continue
 
-        if line.startswith('----'):
+        if line.startswith('^^^^'):
           f.write(line)
           continue
 
         if header_found and add_note_here:
-          if not line.startswith('----'):
+          if not line.startswith('^^^^'):
             f.write("""- New :doc:`%s
   <clang-tidy/checks/%s>` check.
 
   FIXME: add release notes.
 
 """ % (check_name_dashes, check_name_dashes))
             note_added = True
 

clang-tools-extra/clang-tidy/rename_check.py

def add_release_notes(clang_tidy_path, old_check_name, new_check_name):
 
   print('Updating %s...' % filename)
   with open(filename, 'wb') as f:
     note_added = False
     header_found = False
 
     for line in lines:
       if not note_added:
-        match = re.search('Improvements to clang-tidy', line)
+        match = re.search('Renamed checks', line)
         if match:
           header_found = True
         elif header_found:
-          if not line.startswith('----'):
+          if not line.startswith('^^^^'):
             f.write("""
 - The '%s' check was renamed to :doc:`%s
   <clang-tidy/checks/%s>`
 """ % (old_check_name, new_check_name, new_check_name))
             note_added = True
 
       f.write(line)
 

clang-tools-extra/docs/ReleaseNotes.rst

- New :doc:`bugprone-reserved-identifier
   Checks for usages of identifiers reserved for use by the implementation.
   
 - New :doc:`cert-oop57-cpp
   <clang-tidy/checks/cert-oop57-cpp>` check.
   
   Flags use of the `C` standard library functions ``memset``, ``memcpy`` and
   ``memcmp`` and similar derivatives on non-trivial types.
 
-New aliases
-^^^^^^^^^^^
+New check aliases
+^^^^^^^^^^^^^^^^^
 
 - New alias :doc:`cert-dcl37-c
   <clang-tidy/checks/cert-dcl37-c>` to
   :doc:`bugprone-reserved-identifier
   <clang-tidy/checks/bugprone-reserved-identifier>` was added.
 
 - New alias :doc:`cert-dcl51-cpp
   <clang-tidy/checks/cert-dcl51-cpp>` to