This is an archive of the discontinued LLVM Phabricator instance.

Differential D72314

[libcxx] fix incorrect attribute property
ClosedPublic

Authored by kiszk on Jan 6 2020, 9:50 PM.

Details

Reviewers
EricWF
mclow.lists
Jim
Commits
rG9de6a3987251: [libcxx] fix incorrect attribute property
Summary

__has_attribute(fallthough) -> __has_attribute(fallthrough)
This is a follow-up of https://reviews.llvm.org/D72287

Diff Detail

Event Timeline

kiszk created this revision.Jan 6 2020, 9:50 PM
Herald added a reviewer: EricWF. · View Herald TranscriptJan 6 2020, 9:50 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, ldionne, christof. · View Herald Transcript
Harbormaster completed remote builds in B43405: Diff 236517.Jan 6 2020, 9:55 PM
Herald added a reviewer: mclow.lists. · View Herald TranscriptJan 6 2020, 9:55 PM
Jim accepted this revision.Jan 6 2020, 10:08 PM
This revision is now accepted and ready to land.Jan 6 2020, 10:08 PM
kiszk added a comment.EditedJan 7 2020, 12:48 AM

In the original one, the immediate succeeding test was failed at http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1710, but other tests were passed at http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1711.

Jim added a comment.Jan 7 2020, 2:02 AM

It looks like test is passed now. Although I don't know why http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1710 fails.

kiszk added a comment.Jan 7 2020, 6:45 AM

I do not have commit rights to the repository yet. Could someone commit this change if it is OK?
Kazuaki Ishizaki <ishizaki@jp.ibm.com>

kiszk added a comment.Jan 7 2020, 8:40 AM
This comment was removed by kiszk.
Closed by commit rG9de6a3987251: [libcxx] fix incorrect attribute property (authored by kiszk, committed by Jim). · Explain WhyJan 7 2020, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
include/
2 lines

Diff 236725

libcxx/include/__config

Show First 20 Lines • Show All 1,294 Lines • ▼ Show 20 Lines
# define _LIBCPP_DIAGNOSE_ERROR(...) # define _LIBCPP_DIAGNOSE_ERROR(...)
#endif #endif
// Use a function like macro to imply that it must be followed by a semicolon // Use a function like macro to imply that it must be followed by a semicolon
#if __cplusplus > 201402L && __has_cpp_attribute(fallthrough) #if __cplusplus > 201402L && __has_cpp_attribute(fallthrough)
# define _LIBCPP_FALLTHROUGH() [[fallthrough]] # define _LIBCPP_FALLTHROUGH() [[fallthrough]]
#elif __has_cpp_attribute(clang::fallthrough) #elif __has_cpp_attribute(clang::fallthrough)
# define _LIBCPP_FALLTHROUGH() [[clang::fallthrough]] # define _LIBCPP_FALLTHROUGH() [[clang::fallthrough]]
#elif __has_attribute(fallthough) || _GNUC_VER >= 700 #elif __has_attribute(fallthrough) || _GNUC_VER >= 700
# define _LIBCPP_FALLTHROUGH() __attribute__((__fallthrough__)) # define _LIBCPP_FALLTHROUGH() __attribute__((__fallthrough__))
#else #else
# define _LIBCPP_FALLTHROUGH() ((void)0) # define _LIBCPP_FALLTHROUGH() ((void)0)
#endif #endif
#if __has_attribute(__nodebug__) #if __has_attribute(__nodebug__)
#define _LIBCPP_NODEBUG __attribute__((__nodebug__)) #define _LIBCPP_NODEBUG __attribute__((__nodebug__))
#else #else
▲ Show 20 Lines • Show All 206 Lines • Show Last 20 Lines