Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT

[dsanders]

Summary

be15dfa88fb1 broke GlobalISel's usage of getSetCCInverse() which currently
appears to be limited to our out-of-tree backend. GlobalISel doesn't use
EVT's and isn't able to derive them from the information it has as it
doesn't distinguish between integer and floating point types (that
distinction is made by operations rather than values). Bring back the
bool version of getSetCCInverse() in a way that doesn't break the intent
of be15dfa88fb1 but also allows GlobalISel to continue using it.

[dsanders]

Corrected patch

[arichardson]

Could we invert the boolean flag to be isFloat? I fear that calling it isInteger, will lead the the same problems that I tried to fix in that commit (calling .isInteger() returns false for pointers).

[dsanders]

In D72309#1807593, @arichardson wrote:

Could we invert the boolean flag to be isFloat? I fear that calling it isInteger, will lead the the same problems that I tried to fix in that commit (calling .isInteger() returns false for pointers).

GlobalISel's LLT type doesn't have an isInteger() and distinguishes scalars from pointers so I think that's less of a risk for GlobalISel. For SelectionDAG, my guard against misuse is moving it to the GlobalISel namespace so that SelectionDAG code can't call it by accident.

That said, I don't mind inverting it in principle but one risk I see with that is that clangs fixits will direct downstream people to add the namespace but won't point out that the bool is inverted. We could name it isIntegral, isIntegerLike, isIntegerComparison, etc. if that helps.

[arichardson]

Could we an overload that takes LLT instead and keep the boolean flag internal to the .cpp?

[arichardson]

In D72309#1813019, @arichardson wrote:

Could we an overload that takes LLT instead and keep the boolean flag internal to the .cpp?

Never mind, I saw now that LLT doesn't store int/float information. Seems fine to me but I either would either use isFloat or adjust the name of the boolean to isIntegerLike. Ideally also add a comment that pointers should use the integer variant.

[dsanders]

isInteger -> isIntegerLike and comment on pointers needing to use isIntegerLike

[arichardson]

LGTM

llvm/include/llvm/CodeGen/ISDOpcodes.h

   inline unsigned getUnorderedFlavor(CondCode Cond) {
     return ((int)Cond >> 3) & 3;
   }
 
   /// Return the operation corresponding to !(X op Y), where 'op' is a valid
   /// SetCC operation.
   CondCode getSetCCInverse(CondCode Operation, EVT Type);
 
+  namespace GlobalISel {
     /// Return the operation corresponding to !(X op Y), where 'op' is a valid
     /// SetCC operation.
-  CondCode getSetCCInverseInt(CondCode Operation);
-
-  /// Return the operation corresponding to !(X op Y), where 'op' is a valid
-  /// SetCC operation.
-  CondCode getSetCCInverseFloat(CondCode Operation);
+    CondCode getSetCCInverse(CondCode Operation, bool isInteger);
+  } // end namespace GlobalISel
 
   /// Return the operation corresponding to (Y op X) when given the operation
   /// for (X op Y).
   CondCode getSetCCSwappedOperands(CondCode Operation);
 
   /// Return the result of a logical OR between different comparisons of
   /// identical values: ((X op1 Y) | (X op2 Y)). This function returns
   /// SETCC_INVALID if it is not possible to represent the resultant comparison.

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

ISD::CondCode ISD::getSetCCSwappedOperands(ISD::CondCode Operation) {
   // operation.
   unsigned OldL = (Operation >> 2) & 1;
   unsigned OldG = (Operation >> 1) & 1;
   return ISD::CondCode((Operation & ~6) |  // Keep the N, U, E bits
                        (OldL << 1) |       // New G bit
                        (OldG << 2));       // New L bit.
 }
 
-ISD::CondCode ISD::getSetCCInverse(ISD::CondCode Op, EVT Type) {
-  bool IsInteger = Type.isInteger();
-  if (IsInteger)
-    return getSetCCInverseInt(Op);
-  return getSetCCInverseFloat(Op);
-}
-
-ISD::CondCode ISD::getSetCCInverseInt(ISD::CondCode Op) {
+static ISD::CondCode getSetCCInverseImpl(ISD::CondCode Op, bool isInteger) {
   unsigned Operation = Op;
-  Operation ^= 7; // Flip L, G, E bits, but not U.
+  if (isInteger)
+    Operation ^= 7;   // Flip L, G, E bits, but not U.
+  else
+    Operation ^= 15;  // Flip all of the condition bits.
 
   if (Operation > ISD::SETTRUE2)
     Operation &= ~8;  // Don't let N and U bits get set.
 
   return ISD::CondCode(Operation);
 }
 
-ISD::CondCode ISD::getSetCCInverseFloat(ISD::CondCode Op) {
-  unsigned Operation = Op;
-  Operation ^= 15; // Flip all of the condition bits.
-
-  if (Operation > ISD::SETTRUE2)
-    Operation &= ~8;  // Don't let N and U bits get set.
+ISD::CondCode ISD::getSetCCInverse(ISD::CondCode Op, EVT Type) {
+  return getSetCCInverseImpl(Op, Type.isInteger());
+}
 
-  return ISD::CondCode(Operation);
+ISD::CondCode ISD::GlobalISel::getSetCCInverse(ISD::CondCode Op,
+                                               bool isInteger) {
+  return getSetCCInverseImpl(Op, isInteger);
 }
 
 /// For an integer comparison, return 1 if the comparison is a signed operation
 /// and 2 if the result is an unsigned comparison. Return zero if the operation
 /// does not depend on the sign of the input (setne and seteq).
 static int isSignedOp(ISD::CondCode Opcode) {
   switch (Opcode) {
   default: llvm_unreachable("Illegal integer setcc operation!");