This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Correct result type for G_FCMP in lowerFPTOUI
ClosedPublic

Authored by arsenm on Jan 6 2020, 6:14 AM.

Details

Summary

Using the final result type doesn't make any sense. Use the natural
default boolean type for the select condition.

Diff Detail

Event Timeline

arsenm created this revision.Jan 6 2020, 6:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2020, 6:14 AM
paquette accepted this revision.Jan 6 2020, 1:37 PM

LGTM

(I feel like a verifier should have caught this?)

This revision is now accepted and ready to land.Jan 6 2020, 1:37 PM
arsenm added a comment.Jan 6 2020, 1:40 PM

LGTM

(I feel like a verifier should have caught this?)

The return type isn't necessarily wrong based on the target