Page MenuHomePhabricator

AMDGPU: Don't error on ds.ordered intrinsic in function
ClosedPublic

Authored by arsenm on Jan 6 2020, 6:07 AM.

Details

Summary

These should be assumed to be called from a compute context. Also
don't use a 2 entry switch over constants.

Diff Detail

Event Timeline

arsenm created this revision.Jan 6 2020, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2020, 6:07 AM
rampitec added inline comments.Fri, Jan 24, 12:09 PM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
6155

Maybe add an enum?

arsenm marked an inline comment as done.Fri, Jan 24, 12:18 PM
arsenm added inline comments.
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
6155

There probably should be one somewhere, but I don't know where these are defined or set, or what the manual calls this

rampitec accepted this revision.Fri, Jan 24, 12:38 PM
rampitec added inline comments.
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
6155

Sigh.

This revision is now accepted and ready to land.Fri, Jan 24, 12:38 PM