This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Don't create MachinePointerInfos with an UndefValue pointer
ClosedPublic

Authored by foad on Dec 23 2019, 5:47 AM.

Details

Summary

The only useful information the UndefValue conveys is the address space,
which MachinePointerInfo can represent directly without referring to an
IR value.

Diff Detail

Event Timeline

foad created this revision.Dec 23 2019, 5:47 AM

Unit tests: pass. 61096 tests passed, 0 failed and 728 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

foad updated this revision to Diff 235140.Dec 23 2019, 6:27 AM

Remove unused variable.

foad updated this revision to Diff 235141.Dec 23 2019, 6:30 AM

Previous revision included unwanted changes.

Unit tests: pass. 61096 tests passed, 0 failed and 728 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

arsenm accepted this revision.Dec 23 2019, 7:47 AM

LGTM. The undef was also incorrect

This revision is now accepted and ready to land.Dec 23 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.