[cmake] Add dependency on llvm-dwarfdump to llvm-locstats

[DavidSpickett]

Summary

Though llvm-locstat is a "util" it requires llvm-dwarfdump
to be useful. So what happens now is that unless LLVM_BUILD_TOOLS
is ON llvm-locstats won't be part of the "all" target.

However given that it requires llvm-dwarfdump, this is less
confusing/build time consuming than suddenly having llvm-dwarfdump
build when all other tools are disabled.

[djtodoro]

Please make sure the tool name is llvm-locstats instead of llvm-covstat.

(This patch is follow up for the https://reviews.llvm.org/D71695, where is the rest of the conversation).

llvm/utils/llvm-locstats/CMakeLists.txt

12

Please describe, once again, why you decided to use the LLVM_BUILD_UTILS instead of the LLVM_BUILD_TOOLS here.

[DavidSpickett]

In D71705#1791232, @djtodoro wrote:

Please make sure the tool name is llvm-locstats instead of llvm-covstat.

Done.

llvm/utils/llvm-locstats/CMakeLists.txt

12

I was testing both and got confused along the way. LLVM_BUILD_TOOLS is what I intended.

Reasoning being that though llvm-locstats requires llvm-dwarfdump, it would be a bigger problem to start building llvm-dwarfdump when LLVM_BUILD_TOOLS is OFF, than it is to not build llvm-locstats when LLVM_BUILD_UTILS is ON.

(from the point of view of someone trying to trim their build time)

[djtodoro]

Thanks for doing this! Looks good to me now!

llvm/utils/llvm-locstats/CMakeLists.txt

12

That is why I asked this. :)

[DavidSpickett]

Have reverted due to failure on lld-x86_64-ubuntu-fast buildbot, will investigate and re-land.

[DavidSpickett]

Failure was unrelated, re-landed as 0ca9d2fd39264054501927ba6d3c5330159458d7.

llvm/utils/llvm-locstats/CMakeLists.txt

 if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
   add_custom_command(
     OUTPUT ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     DEPENDS ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py
+    DEPENDS llvm-dwarfdump
     COMMAND ${CMAKE_COMMAND} -E copy ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     COMMENT "Copying llvm-locstats into ${LLVM_TOOLS_BINARY_DIR}"
     )
   add_custom_target(llvm-locstats ALL
     DEPENDS ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     )
+  if (NOT LLVM_BUILD_TOOLS)
+    set_target_properties(llvm-locstats PROPERTIES EXCLUDE_FROM_ALL ON)
+  endif()
   set_target_properties(llvm-locstats PROPERTIES FOLDER "Tools")
 endif()